On Sunday 06 August 2017 18:10:12 Andy Shevchenko wrote:
> On Sun, Aug 6, 2017 at 6:35 PM, Pali Rohár
> wrote:
> > On Wednesday 05 July 2017 22:24:20 Pali Rohár wrote:
> >> On Wednesday 05 July 2017 21:30:35 David Airlie wrote:
> >> > > On Saturday 17 June 2017 18:47:54 Pali Rohár wrote:
> >> > >
On Sunday 06 August 2017 18:18:06 Hans de Goede wrote:
> Hi,
>
> On 06-08-17 17:42, Pali Rohár wrote:
> > On Wednesday 14 June 2017 17:46:54 Pali Rohár wrote:
> >> On Tuesday 13 June 2017 11:42:28 Darren Hart wrote:
> >>> On Tue, Jun 13, 2017 at 08:04:57PM +0200, Pali Rohár wrote:
> On Tuesda
Hi,
On 06-08-17 17:42, Pali Rohár wrote:
On Wednesday 14 June 2017 17:46:54 Pali Rohár wrote:
On Tuesday 13 June 2017 11:42:28 Darren Hart wrote:
On Tue, Jun 13, 2017 at 08:04:57PM +0200, Pali Rohár wrote:
On Tuesday 13 June 2017 18:49:51 Darren Hart wrote:
I'd suggest reaching out to the ma
On Sun, Aug 6, 2017 at 6:35 PM, Pali Rohár wrote:
> On Wednesday 05 July 2017 22:24:20 Pali Rohár wrote:
>> On Wednesday 05 July 2017 21:30:35 David Airlie wrote:
>> > > On Saturday 17 June 2017 18:47:54 Pali Rohár wrote:
>> > > > > So problematic drivers which use instance=1 without any
>> > > >
On Wednesday 14 June 2017 17:46:54 Pali Rohár wrote:
> On Tuesday 13 June 2017 11:42:28 Darren Hart wrote:
> > On Tue, Jun 13, 2017 at 08:04:57PM +0200, Pali Rohár wrote:
> > > On Tuesday 13 June 2017 18:49:51 Darren Hart wrote:
> > > > I'd suggest reaching out to the maintainers and contributors t
; , acpi4asus-u...@lists.sourceforge.net,
> > > "Dave Airlie" , "Oleksij Rempel"
> > > , "João Paulo Rechi Vita"
> > >
> > > Cc: "Darren Hart" , "Andy Shevchenko"
> > > , "Andy Lutomirski" ,
> &
uot;Oleksij Rempel"
> > , "João Paulo Rechi Vita"
> >
> > Cc: "Darren Hart" , "Andy Shevchenko"
> > , "Andy Lutomirski" ,
> > platform-driver-...@vger.kernel.org, linux-kernel@vger.kernel.org
> > Sent: Wednesday, 5 July, 201
Cc: "Darren Hart" , "Andy Shevchenko"
> , "Andy Lutomirski"
> , platform-driver-...@vger.kernel.org,
> linux-kernel@vger.kernel.org
> Sent: Wednesday, 5 July, 2017 7:51:13 PM
> Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance
> numbe
On Saturday 17 June 2017 18:47:54 Pali Rohár wrote:
> > So problematic drivers which use instance=1 without any comments are:
> >
> > acer-wmi
> > asus-wmi
> > mxm-wmi
>
> Adding authors & maintainers of those drivers in loop.
Hi!
Dell drivers and acer-wmi are fixed now. So only asus-wmi
infradead.org; l...@kernel.org;
> > platform-driver- x...@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method
> > instance number
> >
> > On Friday 16 June 2017 18:33:54 mario.limoncie...@dell.com wrote:
> &g
2017 10:16 AM
> > > To: 'Pali Rohár' ; Darren Hart
> > > Cc: Andy Shevchenko ;
> > > Andy Lutomirski ;
> > > platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org
> > > Subject: RE: [PATCH] RFC: platform/x86: wmi: Fix check
Hi Pali,
On Sat, Jun 17, 2017 at 06:47:54PM +0200, Pali Rohár wrote:
> > So problematic drivers which use instance=1 without any comments are:
> >
> > acer-wmi
> > asus-wmi
> > mxm-wmi
>
> Adding authors & maintainers of those drivers in loop.
>
> WMI instance number is indexed from zero
> So problematic drivers which use instance=1 without any comments are:
>
> acer-wmi
> asus-wmi
> mxm-wmi
Adding authors & maintainers of those drivers in loop.
WMI instance number is indexed from zero and therefore first instance
number is 0, not 1. Can you check if for drivers and wmi fu
rski ;
> > platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: RE: [PATCH] RFC: platform/x86: wmi: Fix check for method
> > instance number
> >
> > > -Original Message-
> > > From: Pali Rohár [mailto:pali.ro...@gmail.com
enko ; Andy Lutomirski
> ;
> > platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance
> > number
> >
> > Mario, are you able to check if instance number passed to
> > wmi_evalu
Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance
> number
>
> Mario, are you able to check if instance number passed to
> wmi_evaluate_method in following dell WMI drivers is correct and should
> be really 1?
>
> I suspect that it should be ze
Mario, are you able to check if instance number passed to
wmi_evaluate_method in following dell WMI drivers is correct and should
be really 1?
I suspect that it should be zero, as instance number is indexed from
zero.
There is no comment in those dell WMI drivers why it is 1, nor what 1
means.
I
On Wed, Jun 14, 2017 at 05:46:54PM +0200, Pali Rohár wrote:
> On Tuesday 13 June 2017 11:42:28 Darren Hart wrote:
> > On Tue, Jun 13, 2017 at 08:04:57PM +0200, Pali Rohár wrote:
> > > On Tuesday 13 June 2017 18:49:51 Darren Hart wrote:
> > > > I'd suggest reaching out to the maintainers and contrib
On Tuesday 13 June 2017 11:42:28 Darren Hart wrote:
> On Tue, Jun 13, 2017 at 08:04:57PM +0200, Pali Rohár wrote:
> > On Tuesday 13 June 2017 18:49:51 Darren Hart wrote:
> > > I'd suggest reaching out to the maintainers and contributors to the
> > > drivers you mention to request some help in testi
On Tue, Jun 13, 2017 at 08:04:57PM +0200, Pali Rohár wrote:
> On Tuesday 13 June 2017 18:49:51 Darren Hart wrote:
> > On Sat, Jun 10, 2017 at 09:15:57PM +0200, Pali Rohár wrote:
> > > On Saturday 27 May 2017 13:55:34 Pali Rohár wrote:
> > > > instance_count defines number of instances of data block
On Tuesday 13 June 2017 18:49:51 Darren Hart wrote:
> On Sat, Jun 10, 2017 at 09:15:57PM +0200, Pali Rohár wrote:
> > On Saturday 27 May 2017 13:55:34 Pali Rohár wrote:
> > > instance_count defines number of instances of data block and
> > > instance itself is indexed from zero, which means first i
On Sat, Jun 10, 2017 at 09:15:57PM +0200, Pali Rohár wrote:
> On Saturday 27 May 2017 13:55:34 Pali Rohár wrote:
> > instance_count defines number of instances of data block and instance
> > itself is indexed from zero, which means first instance has number 0.
> > Therefore check for invalid instan
On Saturday 27 May 2017 13:55:34 Pali Rohár wrote:
> instance_count defines number of instances of data block and instance
> itself is indexed from zero, which means first instance has number 0.
> Therefore check for invalid instance should be non-strict inequality.
>
> Signed-off-by: Pali Rohár
23 matches
Mail list logo
