Re: [PATCH] Revert "block: simplify set_init_blocksize" to regain lost performance

2021-01-27 Thread Jens Axboe
On 1/26/21 12:59 PM, Maxim Mikityanskiy wrote: > The cited commit introduced a serious regression with SATA write speed, > as found by bisecting. This patch reverts this commit, which restores > write speed back to the values observed before this commit. > > The performance tests were done on a He

Re: [PATCH] Revert "block: simplify set_init_blocksize" to regain lost performance

2021-01-27 Thread Christoph Hellwig
While this code is gross, I think we need to add it back for now: Acked-by: Christoph Hellwig I'll put converting the block device buffered I/O path to iomap or an iomap lookalike on the backburner to fix this..

Re: [PATCH] Revert "block: simplify set_init_blocksize" to regain lost performance

2021-01-27 Thread Ming Lei
On Wed, Jan 27, 2021 at 09:44:50AM +0200, Maxim Mikityanskiy wrote: > On Wed, Jan 27, 2021 at 6:23 AM Bart Van Assche wrote: > > > > On 1/26/21 11:59 AM, Maxim Mikityanskiy wrote: > > > The cited commit introduced a serious regression with SATA write speed, > > > as found by bisecting. This patch

Re: [PATCH] Revert "block: simplify set_init_blocksize" to regain lost performance

2021-01-26 Thread Maxim Mikityanskiy
On Wed, Jan 27, 2021 at 6:23 AM Bart Van Assche wrote: > > On 1/26/21 11:59 AM, Maxim Mikityanskiy wrote: > > The cited commit introduced a serious regression with SATA write speed, > > as found by bisecting. This patch reverts this commit, which restores > > write speed back to the values observe

Re: [PATCH] Revert "block: simplify set_init_blocksize" to regain lost performance

2021-01-26 Thread Bart Van Assche
On 1/26/21 11:59 AM, Maxim Mikityanskiy wrote: > The cited commit introduced a serious regression with SATA write speed, > as found by bisecting. This patch reverts this commit, which restores > write speed back to the values observed before this commit. > > The performance tests were done on a He