RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-04 Thread Jacky.Cao
Hi > Yes. Except that I think the name POWER_BUDGET_3_0 is a little odd. > It implies that this change is specific to USB 3.0 -- but it isn't. > USB 3.1 and 3.2 also have a 900 mA limit, right? > > So please consider changing the name to POWER_BUDGET_3. > > Alan Stern Thank you for your comme

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-04 Thread Alan Stern
On Wed, 4 Sep 2019, Felipe Balbi wrote: > > Hi, > > writes: > > > The power budget for SuperSpeed mode should be 900 mA > > according to USB3.0 specification, so set the power > > budget to 900 mA for dummy_start_ss which is only used > > for SuperSpeed mode. > > > > If the max power consumpti

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-04 Thread Greg KH
On Wed, Sep 04, 2019 at 08:52:12AM +, jacky@sony.com wrote: > Hi, > > > I'm not ok with the whitespace damage making this patch impossible to apply > > :) > > Sorry for the whitespace damage issue I didn't notice when I copied the > content. > Just now I submitted v2 for this patch wit

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-04 Thread Jacky.Cao
Hi, > I'm not ok with the whitespace damage making this patch impossible to apply :) Sorry for the whitespace damage issue I didn't notice when I copied the content. Just now I submitted v2 for this patch with whitespace damage issue fix. Please help to confirm, thank you. Regards Jacky

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-04 Thread Greg KH
On Wed, Sep 04, 2019 at 10:54:28AM +0300, Felipe Balbi wrote: > > Hi, > > writes: > > > The power budget for SuperSpeed mode should be 900 mA > > according to USB3.0 specification, so set the power > > budget to 900 mA for dummy_start_ss which is only used > > for SuperSpeed mode. > > > > If th

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-04 Thread Jacky.Cao
e- From: Felipe Balbi Sent: Wednesday, September 4, 2019 3:47 PM To: Cao, Jacky Cc: Greg KH ; linux-...@vger.kernel.org; Kernel development list ; Kobayashi, Kento (Sony) Subject: Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode Hi, On Wed, Sep 4, 2019 at 9:47 AM wro

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-04 Thread Felipe Balbi
Hi, writes: > The power budget for SuperSpeed mode should be 900 mA > according to USB3.0 specification, so set the power > budget to 900 mA for dummy_start_ss which is only used > for SuperSpeed mode. > > If the max power consumption of SuperSpeed device is > larger than 500 mA, insufficient a

Re: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-04 Thread Felipe Balbi
Hi, On Wed, Sep 4, 2019 at 9:47 AM wrote: > > The power budget for SuperSpeed mode should be 900 mA > > according to USB3.0 specification, so set the power > > budget to 900 mA for dummy_start_ss which is only used > > for SuperSpeed mode. > > > > If the max power consumption of SuperSpeed device

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-03 Thread Kobayashi, Kento (Sony)
d mail by git send mail. So he sent by another mail application. Regards, Kento Kobayashi -Original Message- From: Felipe Balbi Sent: Wednesday, September 4, 2019 3:20 PM To: Kobayashi, Kento (Sony) ; gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; C

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-03 Thread Felipe Balbi
Hi, "Kobayashi, Kento (Sony)" writes: > Hi, > > My company's member, Mr.Jacky, sent patch in June 26th. > But we didn't receive comment about our patch. > Could you confirm and tell us this patch is needed or not? I can't find the original patch in my inbox, could you resend it using git send-

RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode

2019-09-03 Thread Kobayashi, Kento (Sony)
l.org; gre...@linuxfoundation.org Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Kobayashi, Kento (Sony) ; Cao, Jacky Subject: RE: [PATCH] USB: dummy-hcd: fix power budget for SuperSpeed mode Hi, Since around half month past, let me confirm the status of this issue. If any comment about the fix patch,