Re: [PATCH] Workaround for a PCI restoring bug

2007-05-14 Thread Lukas Hejtmanek
On Sun, May 13, 2007 at 11:59:47AM -0700, Andrew Morton wrote: > Possibly we're saving the device's state when it is already partway or > fully through the suspend process, dunno. > > What if you were to put code into pci_save_state() to detect when it reads > an ox? Do a dump_stack() and

Re: [PATCH] Workaround for a PCI restoring bug

2007-05-13 Thread Andrew Morton
On Sun, 13 May 2007 14:21:14 +0200 Lukas Hejtmanek <[EMAIL PROTECTED]> wrote: > On Sun, May 13, 2007 at 02:11:19AM -0700, Andrew Morton wrote: > > > I've also noticed that someone pointed out that for some reason, PCI > > > config > > > space is saved twice, the first is OK, the second saves alre

Re: [PATCH] Workaround for a PCI restoring bug

2007-05-13 Thread Lukas Hejtmanek
On Sun, May 13, 2007 at 02:11:19AM -0700, Andrew Morton wrote: > > I've also noticed that someone pointed out that for some reason, PCI config > > space is saved twice, the first is OK, the second saves already disabled > > devices. Unfortunately, I'm unable to find this discussion in LKM. > > Yea

Re: [PATCH] Workaround for a PCI restoring bug

2007-05-13 Thread Andrew Morton
On Sun, 13 May 2007 10:57:18 +0200 Lukas Hejtmanek <[EMAIL PROTECTED]> wrote: > Hello, > > On Sat, May 12, 2007 at 11:47:43PM -0700, Andrew Morton wrote: > > This change might indeed be a suitable workaround for some busted hardware, > > but we'd need to know quite a bit about the problem before

Re: [PATCH] Workaround for a PCI restoring bug

2007-05-13 Thread Lukas Hejtmanek
Hello, On Sat, May 12, 2007 at 11:47:43PM -0700, Andrew Morton wrote: > This change might indeed be a suitable workaround for some busted hardware, > but we'd need to know quite a bit about the problem before we could merge > anything like this > > So, again, please send a full bug report. An em

Re: [PATCH] Workaround for a PCI restoring bug

2007-05-12 Thread Andrew Morton
On Sat, 12 May 2007 22:12:37 +0200 Lukas Hejtmanek <[EMAIL PROTECTED]> wrote: > as of 2.6.21-git16, the bugs related to restoring PCI are still present. The > save pci function reads only -1 from the PCI config space and when restoring, > it messes up totaly most PCI devices. The attached patch is

Re: [PATCH] Workaround for a PCI restoring bug

2007-05-12 Thread Robert Hancock
Lukas Hejtmanek wrote: Hello, as of 2.6.21-git16, the bugs related to restoring PCI are still present. The save pci function reads only -1 from the PCI config space and when restoring, it messes up totaly most PCI devices. The attached patch is workaround only until proper fix is found and inclu