Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-03-07 Thread Borislav Petkov
On Thu, Mar 07, 2013 at 09:17:03PM +0100, Peter Feuerer wrote: > Finally I found some time to do a test run. I did a git clone on the > Linus tree. But I was not able to apply this patch, seems like it has > already been applied on mainline. Yep, patch is in 3.9-rc1. > Anyhow, with current git st

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-03-07 Thread Peter Feuerer
Hi Boris, Borislav Petkov writes: On Mon, Feb 25, 2013 at 01:16:08PM +0100, Borislav Petkov wrote: On Mon, Feb 25, 2013 at 11:25:26AM +0100, Borislav Petkov wrote: > > has anybody checked if the patch at lkml.org/lkml/2012/12/30/47 fixes > > the problem, without any other patch? > > Ok, let m

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-03-05 Thread Borislav Petkov
On Wed, Mar 06, 2013 at 03:30:28PM +0800, Zhang Rui wrote: > sorry I should be clearer. the problem that alexander' patch fixes, > does not exist in 3.9-rc1 because the problem is fixed by this commit > b8bb6cb999858043489c1ddef08eed2127559169. > > so what we need is, either 3.8.x kernel + alexande

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-03-05 Thread Zhang Rui
On Wed, 2013-03-06 at 08:00 +0100, Borislav Petkov wrote: > On Wed, Mar 06, 2013 at 11:47:20AM +0800, Zhang Rui wrote: > > > So this now does not have any of the Schmitt trigger equivalent (?) > > > governor changes that were nicely discussed in this activity - > > > So what do we want to have comm

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-03-05 Thread Borislav Petkov
On Wed, Mar 06, 2013 at 11:47:20AM +0800, Zhang Rui wrote: > > So this now does not have any of the Schmitt trigger equivalent (?) > > governor changes that were nicely discussed in this activity - > > So what do we want to have committed, and what do we not, > > the problem should have been fixed

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-03-05 Thread Zhang Rui
On Tue, 2013-03-05 at 22:59 +0100, Andreas Mohr wrote: > Hi, > > On Mon, Mar 04, 2013 at 02:34:10PM +0100, Borislav Petkov wrote: > > On Mon, Feb 25, 2013 at 01:16:08PM +0100, Borislav Petkov wrote: > > > Ok, doing a short test here proves successful. I'll run it the next days > > > too to make su

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-03-05 Thread Andreas Mohr
Hi, On Mon, Mar 04, 2013 at 02:34:10PM +0100, Borislav Petkov wrote: > On Mon, Feb 25, 2013 at 01:16:08PM +0100, Borislav Petkov wrote: > > Ok, doing a short test here proves successful. I'll run it the next days > > too to make sure - it would be nice if people could confirm my test > > results,

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-03-04 Thread Andreas Mohr
Hi, On Mon, Mar 04, 2013 at 02:34:10PM +0100, Borislav Petkov wrote: > Pjooiiing! Heh, that was a broken one! Rather well-deserved though - took too much time, been too busy. > Andreas, Peter, can you guys give http://lkml.org/lkml/2012/12/30/47 a run? Will fire up my HDD NOW. About time to get

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-03-04 Thread Borislav Petkov
On Mon, Feb 25, 2013 at 01:16:08PM +0100, Borislav Petkov wrote: > On Mon, Feb 25, 2013 at 11:25:26AM +0100, Borislav Petkov wrote: > > > has anybody checked if the patch at lkml.org/lkml/2012/12/30/47 fixes > > > the problem, without any other patch? > > > > Ok, let me try it out. > > Ok, doing

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-25 Thread Borislav Petkov
On Mon, Feb 25, 2013 at 11:25:26AM +0100, Borislav Petkov wrote: > > has anybody checked if the patch at lkml.org/lkml/2012/12/30/47 fixes > > the problem, without any other patch? > > Ok, let me try it out. Ok, doing a short test here proves successful. I'll run it the next days too to make sure

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-25 Thread Peter Feuerer
Hi, sorry for not answering to earlier mails, but sitting in front of the computer and writing English mails is still very exhausting for me. Borislav Petkov writes: On Mon, Feb 25, 2013 at 11:06:40AM +0800, Zhang Rui wrote: when the temperature goes up to 50C, will the fan be turned on or

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-25 Thread Borislav Petkov
On Mon, Feb 25, 2013 at 11:21:54AM +0800, Zhang Rui wrote: > the reason we keep on calling it because the thermal zone trip point > info may be changed at runtime. > > > Can we pass trip points and temperature levels upon registration time > > instead? > > > no, but we can cache it in the thermal

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-25 Thread Borislav Petkov
On Mon, Feb 25, 2013 at 11:06:40AM +0800, Zhang Rui wrote: > when the temperature goes up to 50C, will the fan be turned on or not? Right, let's first clarify this: so we want the fan to go on when it reaches and/or exceeds the 'fanon' temperature and to go off after it goes under the 'fanoff' te

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-24 Thread Zhang Rui
On Sun, 2013-02-24 at 15:34 +0100, Borislav Petkov wrote: > On Sun, Feb 24, 2013 at 12:42:55PM +0100, Peter Feuerer wrote: > > Please test my last patch with the 4 trip points ;) - even if you > > don't really like it, it is working great! - And to be honest, I still > > prefer this solution! > >

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-24 Thread Zhang Rui
On Sun, 2013-02-24 at 13:09 +0100, Borislav Petkov wrote: > On Sun, Feb 24, 2013 at 12:42:55PM +0100, Peter Feuerer wrote: > > Hi Boris, > > > > thanks for your best wishes in the last mail, I'm feeling little better now. > > Nice :) > > > Please test my last patch with the 4 trip points ;) - ev

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-24 Thread Zhang Rui
On Sun, 2013-02-24 at 12:42 +0100, Peter Feuerer wrote: > Hi Boris, > > thanks for your best wishes in the last mail, I'm feeling little better now. > > Borislav Petkov writes: > > > On Sat, Feb 23, 2013 at 08:20:10PM +0100, Borislav Petkov wrote: > >> From: Borislav Petkov > >> > >> The new s

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-24 Thread Zhang Rui
On Sun, 2013-02-24 at 12:28 +0100, Borislav Petkov wrote: > On Sat, Feb 23, 2013 at 08:20:10PM +0100, Borislav Petkov wrote: > > From: Borislav Petkov > > > > The new step_wise thermal governor wasn't able to handle the one-trip > > point design of acerhdf where we want to turn off the fan if we

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-24 Thread Borislav Petkov
On Sun, Feb 24, 2013 at 12:42:55PM +0100, Peter Feuerer wrote: > Please test my last patch with the 4 trip points ;) - even if you > don't really like it, it is working great! - And to be honest, I still > prefer this solution! Ok, I remember everything now - had to add some debug output to see wh

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-24 Thread Borislav Petkov
On Sun, Feb 24, 2013 at 01:09:52PM +0100, Borislav Petkov wrote: > On Sun, Feb 24, 2013 at 12:42:55PM +0100, Peter Feuerer wrote: > > Hi Boris, > > > > thanks for your best wishes in the last mail, I'm feeling little better now. > > Nice :) > > > Please test my last patch with the 4 trip points

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-24 Thread Borislav Petkov
On Sun, Feb 24, 2013 at 12:42:55PM +0100, Peter Feuerer wrote: > Hi Boris, > > thanks for your best wishes in the last mail, I'm feeling little better now. Nice :) > Please test my last patch with the 4 trip points ;) - even if you > don't really like it, it is working great! - And to be honest,

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-24 Thread Peter Feuerer
Hi Boris, thanks for your best wishes in the last mail, I'm feeling little better now. Borislav Petkov writes: On Sat, Feb 23, 2013 at 08:20:10PM +0100, Borislav Petkov wrote: From: Borislav Petkov The new step_wise thermal governor wasn't able to handle the one-trip point design of acerhdf

Re: [PATCH] acerhdf: Fix fan activation with new thermal governor

2013-02-24 Thread Borislav Petkov
On Sat, Feb 23, 2013 at 08:20:10PM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > The new step_wise thermal governor wasn't able to handle the one-trip > point design of acerhdf where we want to turn off the fan if we go under > the 'fanoff' temperature and to turn it on only after exc