Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 3:25 AM, Aaron Lu wrote: > On 08/02/2013 04:14 PM, Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 3:06 AM, Aaron Lu wrote: >>> On 08/02/2013 03:59 PM, Felipe Contreras wrote: On Fri, Aug 2, 2013 at 1:56 AM, Aaron Lu wrote: > On 08/02/2013 02:44 PM, Felipe Contr

Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-02 Thread Aaron Lu
On 08/02/2013 04:14 PM, Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 3:06 AM, Aaron Lu wrote: >> On 08/02/2013 03:59 PM, Felipe Contreras wrote: >>> On Fri, Aug 2, 2013 at 1:56 AM, Aaron Lu wrote: On 08/02/2013 02:44 PM, Felipe Contreras wrote: >>> > The initial _BCM commands don't w

Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 3:06 AM, Aaron Lu wrote: > On 08/02/2013 03:59 PM, Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 1:56 AM, Aaron Lu wrote: >>> On 08/02/2013 02:44 PM, Felipe Contreras wrote: >> The initial _BCM commands don't work, so the level remains at 100%. Since the level

Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-02 Thread Aaron Lu
On 08/02/2013 03:59 PM, Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 1:56 AM, Aaron Lu wrote: >> On 08/02/2013 02:44 PM, Felipe Contreras wrote: > >>> The initial _BCM commands don't work, so the level remains at 100%. >>> Since the level is max_level, acpi_video_bqc_quirk() tries with the >>

Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 1:56 AM, Aaron Lu wrote: > On 08/02/2013 02:44 PM, Felipe Contreras wrote: >> The initial _BCM commands don't work, so the level remains at 100%. >> Since the level is max_level, acpi_video_bqc_quirk() tries with the >> first level, which is 0, and 0 happens to be the index

Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-01 Thread Aaron Lu
On 08/02/2013 02:44 PM, Felipe Contreras wrote: > On Thu, Aug 1, 2013 at 11:59 PM, Aaron Lu wrote: >> On 08/02/2013 12:50 PM, Felipe Contreras wrote: >>> On Thu, Aug 1, 2013 at 11:30 PM, Aaron Lu wrote: > Please see acpi_video_bqc_quirk, we set _BQC_use_index by revert the level on a r

Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-01 Thread Felipe Contreras
On Thu, Aug 1, 2013 at 11:59 PM, Aaron Lu wrote: > On 08/02/2013 12:50 PM, Felipe Contreras wrote: >> On Thu, Aug 1, 2013 at 11:30 PM, Aaron Lu wrote: >>> Please see acpi_video_bqc_quirk, we set _BQC_use_index by revert the >>> level on a reversed _BCL, so we will need to revert level here too.

Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-01 Thread Aaron Lu
On 08/02/2013 12:50 PM, Felipe Contreras wrote: > On Thu, Aug 1, 2013 at 11:30 PM, Aaron Lu wrote: >> On 08/02/2013 12:11 PM, Felipe Contreras wrote: >>> On Thu, Aug 1, 2013 at 9:03 PM, Aaron Lu wrote: On 08/02/2013 07:34 AM, Felipe Contreras wrote: > Commit 1a7c618 (ACPI video: support

Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-01 Thread Felipe Contreras
On Thu, Aug 1, 2013 at 11:30 PM, Aaron Lu wrote: > On 08/02/2013 12:11 PM, Felipe Contreras wrote: >> On Thu, Aug 1, 2013 at 9:03 PM, Aaron Lu wrote: >>> On 08/02/2013 07:34 AM, Felipe Contreras wrote: Commit 1a7c618 (ACPI video: support _BQC/_BCL/_BCM methods that use index values) ass

Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-01 Thread Aaron Lu
On 08/02/2013 12:11 PM, Felipe Contreras wrote: > On Thu, Aug 1, 2013 at 9:03 PM, Aaron Lu wrote: >> On 08/02/2013 07:34 AM, Felipe Contreras wrote: >>> Commit 1a7c618 (ACPI video: support _BQC/_BCL/_BCM methods that use >>> index values) assumed that bl->levels were not reverted, but at this >>>

Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-01 Thread Felipe Contreras
On Thu, Aug 1, 2013 at 9:03 PM, Aaron Lu wrote: > On 08/02/2013 07:34 AM, Felipe Contreras wrote: >> Commit 1a7c618 (ACPI video: support _BQC/_BCL/_BCM methods that use >> index values) assumed that bl->levels were not reverted, but at this >> point they already are, so there's no need to revert t

Re: [PATCH] acpi: video: fix reversed indexed BQC

2013-08-01 Thread Aaron Lu
On 08/02/2013 07:34 AM, Felipe Contreras wrote: > Commit 1a7c618 (ACPI video: support _BQC/_BCL/_BCM methods that use > index values) assumed that bl->levels were not reverted, but at this > point they already are, so there's no need to revert them yet again. When acpi_video_bqc_value_to_level is