Re: [PATCH] acpi: video: improve quirk check

2013-08-06 Thread Aaron Lu
On 08/04/2013 10:19 PM, Felipe Contreras wrote: > On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki wrote: >> On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: > >>> Personally I think there are better ways to fix the code for the >>> synthetic case than what you patch does, which wi

Re: [PATCH] acpi: video: improve quirk check

2013-08-05 Thread Felipe Contreras
On Mon, Aug 5, 2013 at 9:04 AM, Rafael J. Wysocki wrote: >> In my machine I think the issue is slightly different, I think _BCM is >> failing, at least until enabling the _DOS thing, but at the end of the >> day it's the same thing for the check; _BQC is always returning the >> same value, and th

Re: [PATCH] acpi: video: improve quirk check

2013-08-05 Thread Rafael J. Wysocki
On Sunday, August 04, 2013 09:19:56 AM Felipe Contreras wrote: > On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki wrote: > > On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: > > >> Personally I think there are better ways to fix the code for the > >> synthetic case than what you pa

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Felipe Contreras
On Sun, Aug 4, 2013 at 9:19 AM, Rafael J. Wysocki wrote: > On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: >> Personally I think there are better ways to fix the code for the >> synthetic case than what you patch does, which will also make _BQC >> work. That can be discussed later

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Felipe Contreras
On Sun, Aug 4, 2013 at 9:14 AM, Rafael J. Wysocki wrote: > On Sunday, August 04, 2013 01:54:21 AM Felipe Contreras wrote: >> But we cannot achieve either of those for v3.11, the only >> possibilities seem to be either a) revert efaa14c, or b) keep it and >> apply my patch. Anything else doesn't s

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Rafael J. Wysocki
On Sunday, August 04, 2013 01:42:49 AM Felipe Contreras wrote: > On Sat, Aug 3, 2013 at 8:18 PM, Aaron Lu wrote: > > On 08/03/2013 07:34 PM, Rafael J. Wysocki wrote: > >> On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: > >>> On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: > On Frida

Re: [PATCH] acpi: video: improve quirk check

2013-08-04 Thread Rafael J. Wysocki
On Sunday, August 04, 2013 01:54:21 AM Felipe Contreras wrote: > On Sat, Aug 3, 2013 at 8:47 PM, Aaron Lu wrote: > > On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras > > wrote: > >> On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: > > >>> Do we still need to revert commit efaa14c if thi

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 8:47 PM, Aaron Lu wrote: > On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras > wrote: >> On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: >>> Do we still need to revert commit efaa14c if this patch is applied? >> >> I guess not. At least in this machine changing th

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 8:18 PM, Aaron Lu wrote: > On 08/03/2013 07:34 PM, Rafael J. Wysocki wrote: >> On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: >>> On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: > If the _BCL

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Aaron Lu
On Sun, Aug 4, 2013 at 6:20 AM, Felipe Contreras wrote: > On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: >> On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: >>> On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki wrote: >>> > On Saturday, August 03, 2013 04:14:04 PM Aaron

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Aaron Lu
On 08/03/2013 07:34 PM, Rafael J. Wysocki wrote: > On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: >> On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: >>> On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: If the _BCL package is descending, the first level (br->levels[2])

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 5:38 PM, Rafael J. Wysocki wrote: > On Saturday, August 03, 2013 05:20:33 PM Felipe Contreras wrote: >> On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: >> > On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: >> >> On Sat, Aug 3, 2013 at 6:34 AM, Rafae

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Rafael J. Wysocki
On Saturday, August 03, 2013 05:20:33 PM Felipe Contreras wrote: > On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: > > On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: > >> On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki wrote: > >> > On Saturday, August 03, 2013 04:14:

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 4:40 PM, Rafael J. Wysocki wrote: > On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: >> On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki wrote: >> > On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: >> >> >> Yes, the patch is correct, but I still pre

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Rafael J. Wysocki
On Saturday, August 03, 2013 03:24:16 PM Felipe Contreras wrote: > On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki wrote: > > On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: > > >> Yes, the patch is correct, but I still prefer my own version :-) > >> https://github.com/aaronlu/linux/co

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Felipe Contreras
On Sat, Aug 3, 2013 at 6:34 AM, Rafael J. Wysocki wrote: > On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: >> Yes, the patch is correct, but I still prefer my own version :-) >> https://github.com/aaronlu/linux/commit/0a3d2c5b59caf80ae5bb1ca1fda0f7bf448b38c9 >> >> In case you want to tak

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Rafael J. Wysocki
On Saturday, August 03, 2013 04:14:04 PM Aaron Lu wrote: > On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: > > On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: > >> If the _BCL package is descending, the first level (br->levels[2]) will > >> be 0, and if the number of levels matches

Re: [PATCH] acpi: video: improve quirk check

2013-08-03 Thread Aaron Lu
On 08/03/2013 07:47 AM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: >> If the _BCL package is descending, the first level (br->levels[2]) will >> be 0, and if the number of levels matches the number of steps, we might >> confuse a returned level to mean

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 8:19 PM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 08:07:37 PM Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki wrote: >> > On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: >> >> On Fri, Aug 2, 2013 at 6:47 PM, Rafael J.

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 08:07:37 PM Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki wrote: > > On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: > >> On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki wrote: > >> > On Friday, August 02, 2013 02:37:09 PM

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 8:16 PM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: >> On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki wrote: >> > On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: >> >> If the _BCL package is descending, the fi

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 08:04:52 PM Felipe Contreras wrote: > On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki wrote: > > On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: > >> If the _BCL package is descending, the first level (br->levels[2]) will > >> be 0, and if the number of

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Felipe Contreras
On Fri, Aug 2, 2013 at 6:47 PM, Rafael J. Wysocki wrote: > On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: >> If the _BCL package is descending, the first level (br->levels[2]) will >> be 0, and if the number of levels matches the number of steps, we might >> confuse a returned leve

Re: [PATCH] acpi: video: improve quirk check

2013-08-02 Thread Rafael J. Wysocki
On Friday, August 02, 2013 02:37:09 PM Felipe Contreras wrote: > If the _BCL package is descending, the first level (br->levels[2]) will > be 0, and if the number of levels matches the number of steps, we might > confuse a returned level to mean the index. > > For example: > > current_level = m