Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-17 Thread Denys Vlasenko
On Monday 17 September 2007 11:01, Takashi Iwai wrote: > > There is a lot of data structures in that code, > > and most of them seems to be read-only. > > > > I added const modifiers to most of such places: > > > >textdata bss dec hex filename > > 106315 179564 36 2859

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-17 Thread Takashi Iwai
At Fri, 14 Sep 2007 18:48:05 +0100, Denys Vlasenko wrote: > > Hi Takashi, > > There is a lot of data structures in that code, > and most of them seems to be read-only. > > I added const modifiers to most of such places: > >textdata bss dec hex filename > 106315 179564

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-15 Thread Jan Engelhardt
On Sep 15 2007 14:47, Denys Vlasenko wrote: >> Try size -A instead. > >thanks, didn't know that. > >$ size -A busybox >busybox : >section sizeaddr >.init 28 134512788 >addr in decimal?! wow... Try size -x instead. - To unsubscribe from this list: send the line "unsubscr

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-15 Thread Denys Vlasenko
On Saturday 15 September 2007 13:40, Andreas Schwab wrote: > Denys Vlasenko <[EMAIL PROTECTED]> writes: > > > ELF is not as rigid as old a.out (which had only one text, one data > > and one bss segment per .o file IIRC), but size was born in a.out days, > > so it sort of "translates" ELF into a.ou

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-15 Thread Andreas Schwab
Denys Vlasenko <[EMAIL PROTECTED]> writes: > ELF is not as rigid as old a.out (which had only one text, one data > and one bss segment per .o file IIRC), but size was born in a.out days, > so it sort of "translates" ELF into a.out. Try size -A instead. Andreas. -- Andreas Schwab, SuSE Labs, [E

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-15 Thread Denys Vlasenko
On Saturday 15 September 2007 11:29, Jan Engelhardt wrote: > On Sep 15 2007 12:18, Sam Ravnborg wrote: > >> > textdata bss dec hex filename > >> > 106315 179564 36 285915 45cdb snd-hda-intel.o > >> > 2830512624 36 285711 45c0f snd-hda-intel_patched.o > >> >

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-15 Thread Jan Engelhardt
On Sep 15 2007 12:18, Sam Ravnborg wrote: >> > textdata bss dec hex filename >> > 106315 179564 36 285915 45cdb snd-hda-intel.o >> > 2830512624 36 285711 45c0f snd-hda-intel_patched.o >> >> This is kinda odd. Why did the _text_ size increase by constifying?

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-15 Thread Sam Ravnborg
On Sat, Sep 15, 2007 at 11:43:40AM +0200, Jan Engelhardt wrote: > > On Sep 14 2007 18:48, Denys Vlasenko wrote: > >Hi Takashi, > > > >There is a lot of data structures in that code, > >and most of them seems to be read-only. > > > >I added const modifiers to most of such places: > > > > text

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-15 Thread Jan Engelhardt
On Sep 14 2007 18:48, Denys Vlasenko wrote: >Hi Takashi, > >There is a lot of data structures in that code, >and most of them seems to be read-only. > >I added const modifiers to most of such places: > > textdata bss dec hex filename > 106315 179564 36 285915 45cdb snd-h

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-14 Thread Denys Vlasenko
On Friday 14 September 2007 18:48, Denys Vlasenko wrote: > There is a lot of data structures in that code, > and most of them seems to be read-only. > > I added const modifiers to most of such places: > >textdata bss dec hex filename > 106315 179564 36 285915 45cdb s

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-14 Thread Denys Vlasenko
On Friday 14 September 2007 19:09, Joe Perches wrote: > On Fri, 2007-09-14 at 18:48 +0100, Denys Vlasenko wrote: > > > Patch is attached. > > The SND_HDA_PRESETS define doesn't seem useful. > It's only used once. It is defined in .h file and used in .c file. It is made so because defining stati

Re: [PATCH] add consts where appropriate in sound/pci/hda/*

2007-09-14 Thread Joe Perches
On Fri, 2007-09-14 at 18:48 +0100, Denys Vlasenko wrote: > Patch is attached. The SND_HDA_PRESETS define doesn't seem useful. It's only used once. diff -urp linux-2.6.23-rc6/sound/pci/hda/hda_codec.c linux-2.6.23-rc6.bigdata/sound/pci/hda/hda_codec.c --- linux-2.6.23-rc6/sound/pci/hda/hda_codec