Re: [PATCH] arch/cacheflush: Introduce flush_all_caches()

2022-08-17 Thread Peter Zijlstra
On Tue, Aug 16, 2022 at 11:49:59AM -0700, Dan Williams wrote: > What would have helped is if the secure-erase and unlock definition in > the specification mandated that the device emit cache invalidations for > everything it has mapped when it is erased. However, that has some > holes, and it

Re: [PATCH] arch/cacheflush: Introduce flush_all_caches()

2022-08-17 Thread Peter Zijlstra
On Tue, Aug 16, 2022 at 10:42:03AM -0700, Dan Williams wrote: > I also think this cache_flush_region() API wants a prominent comment > clarifying the limited applicability of this API. I.e. that it is not > for general purpose usage, not for VMs, and only for select bare metal > scenarios that

Re: [PATCH] arch/cacheflush: Introduce flush_all_caches()

2022-08-16 Thread Dan Williams
Davidlohr Bueso wrote: > On Tue, 16 Aug 2022, Dan Williams wrote: > > >On Tue, Aug 16, 2022 at 10:30 AM Davidlohr Bueso wrote: > >> > >> On Tue, 16 Aug 2022, Dan Williams wrote: > >> > >> >Peter Zijlstra wrote: > >> >> On Mon, Aug 15, 2022 at 09:07:06AM -0700, Davidlohr Bueso wrote: > >> >> >

Re: [PATCH] arch/cacheflush: Introduce flush_all_caches()

2022-08-16 Thread Davidlohr Bueso
On Tue, 16 Aug 2022, Dan Williams wrote: On Tue, Aug 16, 2022 at 10:30 AM Davidlohr Bueso wrote: On Tue, 16 Aug 2022, Dan Williams wrote: >Peter Zijlstra wrote: >> On Mon, Aug 15, 2022 at 09:07:06AM -0700, Davidlohr Bueso wrote: >> > diff --git a/arch/x86/include/asm/cacheflush.h

Re: [PATCH] arch/cacheflush: Introduce flush_all_caches()

2022-08-16 Thread Dan Williams
On Tue, Aug 16, 2022 at 10:30 AM Davidlohr Bueso wrote: > > On Tue, 16 Aug 2022, Dan Williams wrote: > > >Peter Zijlstra wrote: > >> On Mon, Aug 15, 2022 at 09:07:06AM -0700, Davidlohr Bueso wrote: > >> > diff --git a/arch/x86/include/asm/cacheflush.h > >> > b/arch/x86/include/asm/cacheflush.h >

Re: [PATCH] arch/cacheflush: Introduce flush_all_caches()

2022-08-16 Thread Davidlohr Bueso
On Tue, 16 Aug 2022, Dan Williams wrote: Peter Zijlstra wrote: On Mon, Aug 15, 2022 at 09:07:06AM -0700, Davidlohr Bueso wrote: > diff --git a/arch/x86/include/asm/cacheflush.h b/arch/x86/include/asm/cacheflush.h > index b192d917a6d0..ce2ec9556093 100644 > ---

Re: [PATCH] arch/cacheflush: Introduce flush_all_caches()

2022-08-16 Thread Dan Williams
Peter Zijlstra wrote: > On Mon, Aug 15, 2022 at 09:07:06AM -0700, Davidlohr Bueso wrote: > > diff --git a/arch/x86/include/asm/cacheflush.h > > b/arch/x86/include/asm/cacheflush.h > > index b192d917a6d0..ce2ec9556093 100644 > > --- a/arch/x86/include/asm/cacheflush.h > > +++

Re: [PATCH] arch/cacheflush: Introduce flush_all_caches()

2022-08-16 Thread Peter Zijlstra
On Mon, Aug 15, 2022 at 09:07:06AM -0700, Davidlohr Bueso wrote: > diff --git a/arch/x86/include/asm/cacheflush.h > b/arch/x86/include/asm/cacheflush.h > index b192d917a6d0..ce2ec9556093 100644 > --- a/arch/x86/include/asm/cacheflush.h > +++ b/arch/x86/include/asm/cacheflush.h > @@ -10,4 +10,7 @@