Re: [PATCH] arm64: dts: msm8916: Add interconnect provider DT nodes

[Stephan Gerhold]

Hi Georgi,

On Wed, Jun 17, 2020 at 04:45:15PM +0300, Georgi Djakov wrote:
> Add nodes for the network-on-chip interconnect buses present on
> MSM8916-based platforms.
> 
> Signed-off-by: Georgi Djakov <georgi.dja...@linaro.org>

Thanks for resending this patch!

I tested this recently: it seems to probe fine and request the related
clocks; without interconnect consumers nothing is different otherwise
(as expected). FWIW:

Tested-by: Stephan Gerhold <step...@gerhold.net>

> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 28 +++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi 
> b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 32bd140ac9fd..6c57896d9836 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -4,6 +4,7 @@
>   */
>  
>  #include <dt-bindings/arm/coresight-cti-dt.h>
> +#include <dt-bindings/interconnect/qcom,msm8916.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/clock/qcom,gcc-msm8916.h>
>  #include <dt-bindings/reset/qcom,gcc-msm8916.h>
> @@ -406,11 +407,38 @@ soc: soc {
>               ranges = <0 0 0 0xffffffff>;
>               compatible = "simple-bus";
>  
> +             bimc: interconnect@400000 {
> +                     compatible = "qcom,msm8916-bimc";
> +                     reg = <0x00400000 0x62000>;
> +                     #interconnect-cells = <1>;
> +                     clock-names = "bus", "bus_a";
> +                     clocks = <&rpmcc RPM_SMD_BIMC_CLK>,
> +                              <&rpmcc RPM_SMD_BIMC_A_CLK>;
> +             };
> +
>               restart@4ab000 {
>                       compatible = "qcom,pshold";
>                       reg = <0x4ab000 0x4>;
>               };
>  
> +             pcnoc: interconnect@500000 {
> +                     compatible = "qcom,msm8916-pcnoc";
> +                     reg = <0x00500000 0x11000>;
> +                     #interconnect-cells = <1>;
> +                     clock-names = "bus", "bus_a";
> +                     clocks = <&rpmcc RPM_SMD_PCNOC_CLK>,
> +                              <&rpmcc RPM_SMD_PCNOC_A_CLK>;
> +             };
> +
> +             snoc: interconnect@580000 {
> +                     compatible = "qcom,msm8916-snoc";
> +                     reg = <0x00580000 0x14000>;
> +                     #interconnect-cells = <1>;
> +                     clock-names = "bus", "bus_a";
> +                     clocks = <&rpmcc RPM_SMD_SNOC_CLK>,
> +                              <&rpmcc RPM_SMD_SNOC_A_CLK>;
> +             };
> +
>               msmgpio: pinctrl@1000000 {
>                       compatible = "qcom,msm8916-pinctrl";
>                       reg = <0x1000000 0x300000>;