Re: [PATCH] arm64: fix pud_huge() for 2-level pagetables

2014-05-16 Thread Catalin Marinas
On Fri, May 16, 2014 at 04:54:11PM +0100, Mark Salter wrote: > On Fri, 2014-05-16 at 11:04 +0100, Catalin Marinas wrote: > > On Thu, May 15, 2014 at 03:19:22PM +0100, Mark Salter wrote: > > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > > > index 5e9aec3..9bed38f 100644

Re: [PATCH] arm64: fix pud_huge() for 2-level pagetables

2014-05-16 Thread Mark Salter
On Fri, 2014-05-16 at 11:04 +0100, Catalin Marinas wrote: > On Thu, May 15, 2014 at 03:19:22PM +0100, Mark Salter wrote: > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > > index 5e9aec3..9bed38f 100644 > > --- a/arch/arm64/mm/hugetlbpage.c > > +++ b/arch/arm64/mm/hugetlb

Re: [PATCH] arm64: fix pud_huge() for 2-level pagetables

2014-05-16 Thread Catalin Marinas
On Thu, May 15, 2014 at 03:19:22PM +0100, Mark Salter wrote: > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index 5e9aec3..9bed38f 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -51,7 +51,11 @@ int pmd_huge(pmd_t pmd) > > int pud_h

Re: [PATCH] arm64: fix pud_huge() for 2-level pagetables

2014-05-16 Thread Catalin Marinas
On Thu, May 15, 2014 at 07:39:17PM +0100, Mark Salter wrote: > On Thu, 2014-05-15 at 18:55 +0100, Steve Capper wrote: > > On 15 May 2014 17:27, Mark Salter wrote: > > > On Thu, 2014-05-15 at 15:44 +0100, Steve Capper wrote: > > >> On Thu, May 15, 2014 at 10:19:22AM -0400, Mark Salter wrote: > > >>

Re: [PATCH] arm64: fix pud_huge() for 2-level pagetables

2014-05-15 Thread Mark Salter
On Thu, 2014-05-15 at 18:55 +0100, Steve Capper wrote: > On 15 May 2014 17:27, Mark Salter wrote: > > On Thu, 2014-05-15 at 15:44 +0100, Steve Capper wrote: > >> On Thu, May 15, 2014 at 10:19:22AM -0400, Mark Salter wrote: > >> > The following happens when trying to run a kvm guest on a kernel > >

Re: [PATCH] arm64: fix pud_huge() for 2-level pagetables

2014-05-15 Thread Steve Capper
On 15 May 2014 17:27, Mark Salter wrote: > On Thu, 2014-05-15 at 15:44 +0100, Steve Capper wrote: >> On Thu, May 15, 2014 at 10:19:22AM -0400, Mark Salter wrote: >> > The following happens when trying to run a kvm guest on a kernel >> > configured for 64k pages. This doesn't happen with 4k pages:

Re: [PATCH] arm64: fix pud_huge() for 2-level pagetables

2014-05-15 Thread Mark Salter
On Thu, 2014-05-15 at 15:44 +0100, Steve Capper wrote: > On Thu, May 15, 2014 at 10:19:22AM -0400, Mark Salter wrote: > > The following happens when trying to run a kvm guest on a kernel > > configured for 64k pages. This doesn't happen with 4k pages: > > > > BUG: failure at include/linux/mm.h:2

Re: [PATCH] arm64: fix pud_huge() for 2-level pagetables

2014-05-15 Thread Steve Capper
On Thu, May 15, 2014 at 10:19:22AM -0400, Mark Salter wrote: > The following happens when trying to run a kvm guest on a kernel > configured for 64k pages. This doesn't happen with 4k pages: > > BUG: failure at include/linux/mm.h:297/put_page_testzero()! > Kernel panic - not syncing: BUG! >