Re: [PATCH] ath9k : Fix ieee80211 work while going to suspend

2013-03-24 Thread Parag Warudkar
On Fri, Mar 22, 2013 at 11:08 AM, Luis R. Rodriguez wrote: > On Fri, Mar 22, 2013 at 10:13:42AM +0100, Stanislaw Gruszka wrote: >> On Thu, Mar 21, 2013 at 12:33:31PM -0700, Luis R. Rodriguez wrote: >> > OK how about this for stable for now: >> > >> > diff --git a/drivers/net/wireless/ath/ath9k/lin

Re: [PATCH] ath9k : Fix ieee80211 work while going to suspend

2013-03-22 Thread Luis R. Rodriguez
On Fri, Mar 22, 2013 at 10:13:42AM +0100, Stanislaw Gruszka wrote: > On Thu, Mar 21, 2013 at 12:33:31PM -0700, Luis R. Rodriguez wrote: > > OK how about this for stable for now: > > > > diff --git a/drivers/net/wireless/ath/ath9k/link.c > > b/drivers/net/wireless/ath/ath9k/link.c > > index 39c84e

Re: [PATCH] ath9k : Fix ieee80211 work while going to suspend

2013-03-22 Thread Stanislaw Gruszka
On Thu, Mar 21, 2013 at 12:33:31PM -0700, Luis R. Rodriguez wrote: > So when does this work get called? > > Given the trace this is hit when the timer rx_poll_timer runs, > which in turn calls ath_rx_poll() to schedule hw_check_work work. > The rx_poll_timer however was originally only set at the

Re: [PATCH] ath9k : Fix ieee80211 work while going to suspend

2013-03-21 Thread Luis R. Rodriguez
On Thu, Mar 21, 2013 at 12:42:20PM +0100, Stanislaw Gruszka wrote: > On Mon, Mar 18, 2013 at 02:03:08PM -0700, Luis R. Rodriguez wrote: > > > > --- a/drivers/net/wireless/ath/ath9k/link.c > > > > +++ b/drivers/net/wireless/ath/ath9k/link.c > > > > @@ -158,7 +158,8 @@ void ath_start_rx_poll(struct a

Re: [PATCH] ath9k : Fix ieee80211 work while going to suspend

2013-03-21 Thread Stanislaw Gruszka
On Mon, Mar 18, 2013 at 02:03:08PM -0700, Luis R. Rodriguez wrote: > > > --- a/drivers/net/wireless/ath/ath9k/link.c > > > +++ b/drivers/net/wireless/ath/ath9k/link.c > > > @@ -158,7 +158,8 @@ void ath_start_rx_poll(struct ath_softc *sc, u8 > > > nbeacon) > > > { > > > if (!AR_SREV_9300(sc->sc_

Re: [PATCH] ath9k : Fix ieee80211 work while going to suspend

2013-03-18 Thread Parag Warudkar
On Mon, 18 Mar 2013, Luis R. Rodriguez wrote: > > Note that what this will do is call later mod_timer() for > rx_poll_timer, the right thing to do then, which would > be equivalent to your patch is to modify the ath_start_rx_poll() > to instead use the new API mod_timer_pending() added on v2.6.

Re: [PATCH] ath9k : Fix ieee80211 work while going to suspend

2013-03-18 Thread Luis R. Rodriguez
On Mon, Mar 18, 2013 at 03:13:41PM -0400, John W. Linville wrote: > Any comments from the ath9k folks? > > On Sat, Mar 16, 2013 at 12:38:14PM -0400, Parag Warudkar wrote: > > During suspend below warning is seen when ath9k is active. Attached > > patch fixes the warning for me. Tested to work acr

Re: [PATCH] ath9k : Fix ieee80211 work while going to suspend

2013-03-18 Thread John W. Linville
Any comments from the ath9k folks? On Sat, Mar 16, 2013 at 12:38:14PM -0400, Parag Warudkar wrote: > During suspend below warning is seen when ath9k is active. Attached > patch fixes the warning for me. Tested to work across few > suspend-resume cycles. > > > Mar 16 09:39:17 Parags-iMac kernel: