Re: [PATCH] bcache: Take data offset from the bdev superblock.

2013-04-08 Thread Gabriel de Perthuis
As for BCACHE_SB_VERSION_CDEV_WITH_UUID, can you explain why you added that? I suspect it's needed but I can't remember why I didn't add it when I added the new UUID format (or perhaps I just forgot) I took the name from a comment in the kernel-side bcache.h. BCACHE_SB_VERSION_CDEV is the versio

Re: [PATCH] bcache: Take data offset from the bdev superblock.

2013-04-08 Thread Gabriel
Le lun. 08 avril 2013 22:49:56 CEST, Kent Overstreet a écrit : On Mon, Apr 08, 2013 at 12:11:06PM +0200, Gabriel wrote: Add a new superblock version, and consolidate related defines. So, I think BDEV_WITH_OFFSET looks ok, but what's the use case for it? I was going to add it way back but we de

Re: [PATCH] bcache: Take data offset from the bdev superblock.

2013-04-08 Thread Kent Overstreet
On Mon, Apr 08, 2013 at 12:11:06PM +0200, Gabriel wrote: > Add a new superblock version, and consolidate related defines. So, I think BDEV_WITH_OFFSET looks ok, but what's the use case for it? I was going to add it way back but we decided not to implement the hack we thought we needed it for - if