Re: [PATCH] brcmfmac: cfg80211: use msecs_to_jiffies for time conversion

2015-03-18 Thread Joe Perches
On Wed, 2015-03-18 at 07:44 +0100, Nicholas Mc Guire wrote: > On Tue, 17 Mar 2015, Joe Perches wrote: > > On Tue, 2015-03-17 at 08:06 -0400, Nicholas Mc Guire wrote: > > > Converting milliseconds to jiffies by "val * HZ / 1000" is technically > > > OK but msecs_to_jiffies(val) is the cleaner soluti

Re: [PATCH] brcmfmac: cfg80211: use msecs_to_jiffies for time conversion

2015-03-17 Thread Nicholas Mc Guire
On Tue, 17 Mar 2015, Joe Perches wrote: > On Tue, 2015-03-17 at 08:06 -0400, Nicholas Mc Guire wrote: > > Converting milliseconds to jiffies by "val * HZ / 1000" is technically > > OK but msecs_to_jiffies(val) is the cleaner solution and handles all > > corner cases correctly. This is a minor API

Re: [PATCH] brcmfmac: cfg80211: use msecs_to_jiffies for time conversion

2015-03-17 Thread Joe Perches
On Tue, 2015-03-17 at 08:06 -0400, Nicholas Mc Guire wrote: > Converting milliseconds to jiffies by "val * HZ / 1000" is technically > OK but msecs_to_jiffies(val) is the cleaner solution and handles all > corner cases correctly. This is a minor API consolidation only and > should make things more

Re: [PATCH] brcmfmac: cfg80211: use msecs_to_jiffies for time conversion

2015-03-17 Thread Arend van Spriel
On 03/17/15 13:06, Nicholas Mc Guire wrote: Converting milliseconds to jiffies by "val * HZ / 1000" is technically OK but msecs_to_jiffies(val) is the cleaner solution and handles all corner cases correctly. This is a minor API consolidation only and should make things more readable. Patch was c