Re: [PATCH] btrfs: unlock i_mutex after attempting to delete subvolume during send

2015-03-30 Thread David Sterba
On Sat, Mar 28, 2015 at 11:37:43AM +, Filipe David Manana wrote: > On Sat, Mar 28, 2015 at 11:02 AM, Omar Sandoval wrote: > > Whenever the check for a send in progress introduced in commit > > 521e0546c970 (btrfs: protect snapshots from deleting during send) is > > hit, we return without unloc

Re: [PATCH] btrfs: unlock i_mutex after attempting to delete subvolume during send

2015-03-30 Thread David Sterba
On Sat, Mar 28, 2015 at 04:02:06AM -0700, Omar Sandoval wrote: > Whenever the check for a send in progress introduced in commit > 521e0546c970 (btrfs: protect snapshots from deleting during send) is > hit, we return without unlocking inode->i_mutex. This is easy to see > with lockdep enabled: > >

Re: [PATCH] btrfs: unlock i_mutex after attempting to delete subvolume during send

2015-03-28 Thread Filipe David Manana
On Sat, Mar 28, 2015 at 11:02 AM, Omar Sandoval wrote: > Whenever the check for a send in progress introduced in commit > 521e0546c970 (btrfs: protect snapshots from deleting during send) is > hit, we return without unlocking inode->i_mutex. This is easy to see > with lockdep enabled: > > [ +0.00