Hello,
On Wed, Oct 25, 2017 at 02:54:23PM -0700, Matthias Kaehlcke wrote:
> From your earlier comment I understand that there is no problem in
> this case because we know that cgroup_root->cgrp will always be
> empty.
>
> However in other instances the warning could point out actual errors
> in t
Hi Tejun,
El Sat, Oct 21, 2017 at 08:32:53AM -0700 Tejun Heo ha dit:
> Hello, Nick.
>
> On Fri, Oct 20, 2017 at 12:15:55AM -0700, Nick Desaulniers wrote:
> > > This is silly tho. We know the the root group embedded there won't
> > > have any ancestor_ids.
> >
> > Sure, but struct cgroup_root i
On Sat, Oct 21, 2017 at 9:03 AM, Tejun Heo wrote:
> The kernel is explicitly using GNU extended version of C and has
> always from the beginning, so not-std-c isn't a valid argument.
Ok, how about that it looks like gcc7.1 starts treating this as an error?
https://godbolt.org/g/ivzPHZ
gcc6.3 lo
On Sun, Oct 22, 2017 at 02:59:33AM +1100, Aleksa Sarai wrote:
> >Here, not necessarily but I don't want to move it for a bogus reason.
> >Why would we disallow embedding structs with flexible members in the
> >middle when it can be done and is useful? If we want to discuss
> >whether we want to av
Here, not necessarily but I don't want to move it for a bogus reason.
Why would we disallow embedding structs with flexible members in the
middle when it can be done and is useful? If we want to discuss
whether we want to avoid such usages in the kernel (but why?), sure,
let's have that discussio
Hello, Nick.
On Fri, Oct 20, 2017 at 12:15:55AM -0700, Nick Desaulniers wrote:
> > This is silly tho. We know the the root group embedded there won't
> > have any ancestor_ids.
>
> Sure, but struct cgroup_root is still declared as having a struct
> cgroup not declared as the final member.
Why i
On Wed, Oct 18, 2017 at 6:30 AM, Tejun Heo wrote:
> On Mon, Oct 16, 2017 at 11:33:21PM -0700, Nick Desaulniers wrote:
>> When compiling arch/x86/boot/compressed/eboot.c with HOSTCC=clang, the
>> following warning is observed:
>>
>> ./include/linux/cgroup-defs.h:391:16: warning: field 'cgrp' with
>
Hello,
On Mon, Oct 16, 2017 at 11:33:21PM -0700, Nick Desaulniers wrote:
> When compiling arch/x86/boot/compressed/eboot.c with HOSTCC=clang, the
> following warning is observed:
>
> ./include/linux/cgroup-defs.h:391:16: warning: field 'cgrp' with
> variable sized type 'struct cgroup' not at the
On Mon, Oct 16, 2017 at 11:40 PM, Nick Desaulniers
wrote:
> On Mon, Oct 16, 2017 at 11:33:21PM -0700, Nick Desaulniers wrote:
>> When compiling arch/x86/boot/compressed/eboot.c with HOSTCC=clang, the
>
> Actually, not sure this is because HOSTCC was specifically clang, I
> think that could be rewo
On Mon, Oct 16, 2017 at 11:33:21PM -0700, Nick Desaulniers wrote:
> When compiling arch/x86/boot/compressed/eboot.c with HOSTCC=clang, the
Actually, not sure this is because HOSTCC was specifically clang, I
think that could be reworded to `When compiling ... with Clang, the
...`.
10 matches
Mail list logo
