Re: [PATCH] checkpatch: fix use via symlink, make missing spelling file non-fatal

2014-10-24 Thread Andy Whitcroft
On Fri, Oct 24, 2014 at 02:31:50AM -0700, Joe Perches wrote: > On Fri, 2014-10-24 at 10:02 +0100, Andy Whitcroft wrote: > > On Thu, Oct 23, 2014 at 10:29:11AM -0700, Joe Perches wrote: > > > > [...] > > > my $P = $0; > > > -$P =~ s@(.*)/@@g; > > > -my $D = $1; > > > +my $D = dirname(abs_path($P))

Re: [PATCH] checkpatch: fix use via symlink, make missing spelling file non-fatal

2014-10-24 Thread Joe Perches
On Fri, 2014-10-24 at 10:02 +0100, Andy Whitcroft wrote: > On Thu, Oct 23, 2014 at 10:29:11AM -0700, Joe Perches wrote: > > [...] > > my $P = $0; > > -$P =~ s@(.*)/@@g; > > -my $D = $1; > > +my $D = dirname(abs_path($P)); > > That changes the value of $P, I don't know if that is intended: > >

Re: [PATCH] checkpatch: fix use via symlink, make missing spelling file non-fatal

2014-10-24 Thread Andy Whitcroft
On Thu, Oct 23, 2014 at 10:29:11AM -0700, Joe Perches wrote: [...] > my $P = $0; > -$P =~ s@(.*)/@@g; > -my $D = $1; > +my $D = dirname(abs_path($P)); That changes the value of $P, I don't know if that is intended: my $D = dirname(abs_path($0)); or my $D = abs_path($1); perhaps to keep $

Re: [PATCH] checkpatch: fix use via symlink, make missing spelling file non-fatal

2014-10-23 Thread Kees Cook
On Thu, Oct 23, 2014 at 10:29 AM, Joe Perches wrote: > Commit 66b47b4a9dad ("checkpatch: look for common misspellings") > made it difficult to use checkpatch via a symlink. > > Fix that and make a missing spelling.txt file non-fatal. > Emit a warning when the spelling.txt file can not be opened. >