Re: [PATCH] checkpatch: warn if changed lines exceeds a maximum size

2018-02-01 Thread Jonathan Corbet
On Thu, 1 Feb 2018 15:42:35 + "Brown, Nicholas" wrote: > > I think the metric is too simplistic and > > not particularly useful. > > I'm not sure it's any more simplistic than than the character line > length limit, which is there to prompt thought on code nesting levels, > etc. And as it

Re: [PATCH] checkpatch: warn if changed lines exceeds a maximum size

2018-02-01 Thread Brown, Nicholas
On Thu, 2018-02-01 at 04:54 -0800, Joe Perches wrote: > On Thu, 2018-02-01 at 10:38 +, Brown, Nicholas wrote: > > Hi, > > > > Would one of you be happy to pick this patch up for carrying into > > the next release? > > Not me. > > I think the metric is too simplistic and > not particularly us

Re: [PATCH] checkpatch: warn if changed lines exceeds a maximum size

2018-02-01 Thread Joe Perches
On Thu, 2018-02-01 at 10:38 +, Brown, Nicholas wrote: > Hi, > > Would one of you be happy to pick this patch up for carrying into the next > release? Not me. I think the metric is too simplistic and not particularly useful. If others want it, I think you should try to build or find a bit m

Re: [PATCH] checkpatch: warn if changed lines exceeds a maximum size

2018-01-30 Thread Brown, Nicholas
On Tue, 2018-01-30 at 11:09 -0800, Joe Perches wrote: > On Tue, 2018-01-30 at 19:01 +, Nicholas Brown wrote: > > Changed lines is the total of inserted and deleted lines. > > By default there is no limit, --max-changed-lines may be used to > > set a > > value. Some users may wish to encourage t

Re: [PATCH] checkpatch: warn if changed lines exceeds a maximum size

2018-01-30 Thread Joe Perches
On Tue, 2018-01-30 at 19:01 +, Nicholas Brown wrote: > Changed lines is the total of inserted and deleted lines. > By default there is no limit, --max-changed-lines may be used to set a > value. Some users may wish to encourage that patches are split into > smaller parts using this. > See Docum

Re: [PATCH] checkpatch: warn if changed lines exceeds a maximum size

2018-01-30 Thread Brown, Nicholas
On Tue, 2018-01-30 at 08:10 -0800, Joe Perches wrote: > On Tue, 2018-01-30 at 15:57 +, Brown, Nicholas wrote: > > Changed lines is the total of inserted and deleted lines. > > By default there is no limit, --max-changed-lines may be used to > > set a > > value. Some users may wish to encourage

Re: [PATCH] checkpatch: warn if changed lines exceeds a maximum size

2018-01-30 Thread Joe Perches
On Tue, 2018-01-30 at 15:57 +, Brown, Nicholas wrote: > Changed lines is the total of inserted and deleted lines. > By default there is no limit, --max-changed-lines may be used to set a > value. Some users may wish to encourage that patches are split into > smaller parts using this. > See Docu