Re: [PATCH] clocksource/drivers: Fix error handling in ttc_setup_clocksource

2019-10-23 Thread Markus Elfring
> Fixes: e932900a3279 ("arm: zynq: Use standard timer binding") I find the commit 70504f311d4bd5b6a6d494f50c5ab0bd30fdf75c ("clocksource/drivers/cadence_ttc: Convert init function to return error" from 2016-06-28) also interesting (besides the contribution from 2013-04-04) for your software upda

Re: [PATCH] clocksource/drivers: Fix error handling in ttc_setup_clocksource

2019-10-23 Thread Markus Elfring
> Fixes: e932900a3279 ("arm: zynq: Use standard timer binding") How do you think about to add the tag “Reported-by” for Michal Simek? https://lore.kernel.org/linux-arm-kernel/2a6cdb63-397b-280a-7379-740e8f43d...@xilinx.com/ https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do

Re: [PATCH] clocksource/drivers: Fix error handling in ttc_setup_clocksource

2019-10-23 Thread Markus Elfring
> In the implementation of ttc_setup_clocksource() when > clk_notifier_register() fails the execution should go to error handling. > Additionally, to avoid memory leak the allocated memory for ttccs should > be released, too. I got other wording preferences. Thus I imagine that such a change descr