Re: [PATCH] csi: libcxgbi: remove redundant check and close on csk

2017-09-15 Thread Martin K. Petersen
Colin, > csk is always null on the error return path and so the non-null check > and call to cxgbi_sock_closed on csk is redundant and can be removed. Applied to 4.15/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] csi: libcxgbi: remove redundant check and close on csk

2017-09-11 Thread Varun Prakash
On Thu, Sep 07, 2017 at 02:51:33PM +0100, Colin King wrote: > From: Colin Ian King > > csk is always null on the error return path and so the non-null > check and call to cxgbi_sock_closed on csk is redundant and > can be removed. > > Detected by: CoverityScan CID#114329 ("Logically dead code")