Re: [PATCH] cxl: Delete an unnecessary check before the function call "of_node_put"

2016-07-27 Thread Andrew Donnellan
On 20/07/16 23:38, Julia Lawall wrote: I don't think that the call should be there at all. The loop only exits when afu_np is NULL. Furthermore, the loop should not be written as a for loop, but rather with for_each_child_of_node. Will send a patch to fix both issues shortly. -- Andrew Donne

Re: [PATCH] cxl: Delete an unnecessary check before the function call "of_node_put"

2016-07-20 Thread Julia Lawall
On Wed, 20 Jul 2016, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 20 Jul 2016 15:10:32 +0200 > > The of_node_put() function tests whether its argument is NULL > and then returns immediately. > Thus the test around the call is not needed. > > This issue was detected by using the