Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-21 Thread Dave Jiang
On 07/21/2017 12:57 AM, Vinod Koul wrote: > On Thu, Jul 20, 2017 at 09:56:45AM -0700, Dave Jiang wrote: >> >> >> On 07/20/2017 12:24 AM, walter harms wrote: >>> >>> >>> Am 20.07.2017 00:16, schrieb Christophe JAILLET: If the 'memcmp' fails, free allocated resources as done in all other

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-21 Thread Dan Carpenter
I'm with Christophe. ;) I never like it when people get creative with the last test in a series of tests. regards, dan carpenter

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-21 Thread Vinod Koul
On Thu, Jul 20, 2017 at 09:56:45AM -0700, Dave Jiang wrote: > > > On 07/20/2017 12:24 AM, walter harms wrote: > > > > > > Am 20.07.2017 00:16, schrieb Christophe JAILLET: > >> If the 'memcmp' fails, free allocated resources as done in all other > >> error handling paths. > >> > >> Signed-off-by

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-21 Thread Julia Lawall
On Fri, 21 Jul 2017, walter harms wrote: > > > Am 20.07.2017 18:56, schrieb Dave Jiang: > > > > > > On 07/20/2017 12:24 AM, walter harms wrote: > >> > >> > >> Am 20.07.2017 00:16, schrieb Christophe JAILLET: > >>> If the 'memcmp' fails, free allocated resources as done in all other > >>> error h

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-21 Thread walter harms
Am 20.07.2017 18:56, schrieb Dave Jiang: > > > On 07/20/2017 12:24 AM, walter harms wrote: >> >> >> Am 20.07.2017 00:16, schrieb Christophe JAILLET: >>> If the 'memcmp' fails, free allocated resources as done in all other >>> error handling paths. >>> >>> Signed-off-by: Christophe JAILLET >>>

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-20 Thread Jiang, Dave
> On Jul 20, 2017, at 11:28 PM, Koul, Vinod wrote: > >> On Wed, Jul 19, 2017 at 03:21:23PM -0700, Dave Jiang wrote: >> >> >>> On 07/19/2017 03:16 PM, Christophe JAILLET wrote: >>> If the 'memcmp' fails, free allocated resources as done in all other >>> error handling paths. >>> >>> Signed-of

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-20 Thread Vinod Koul
On Wed, Jul 19, 2017 at 03:21:23PM -0700, Dave Jiang wrote: > > > On 07/19/2017 03:16 PM, Christophe JAILLET wrote: > > If the 'memcmp' fails, free allocated resources as done in all other > > error handling paths. > > > > Signed-off-by: Christophe JAILLET You meant acked right..? > > Good c

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-20 Thread Dave Jiang
On 07/20/2017 12:24 AM, walter harms wrote: > > > Am 20.07.2017 00:16, schrieb Christophe JAILLET: >> If the 'memcmp' fails, free allocated resources as done in all other >> error handling paths. >> >> Signed-off-by: Christophe JAILLET >> --- >> Please review carefully, this patch looks "too o

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-20 Thread walter harms
Am 20.07.2017 00:16, schrieb Christophe JAILLET: > If the 'memcmp' fails, free allocated resources as done in all other > error handling paths. > > Signed-off-by: Christophe JAILLET > --- > Please review carefully, this patch looks "too obvious" to me! > --- > drivers/dma/ioat/init.c | 2 +- >

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-19 Thread Dave Jiang
On 07/19/2017 03:16 PM, Christophe JAILLET wrote: > If the 'memcmp' fails, free allocated resources as done in all other > error handling paths. > > Signed-off-by: Christophe JAILLET Good catch! Thanks. Signed-off-by: Dave Jiang > --- > Please review carefully, this patch looks "too obvious