Re: [PATCH] dmaengine: stm32-dma: fix residue calculation in stm32-dma

2019-04-30 Thread Vinod Koul
On 30-04-19, 16:58, Arnaud Pouliquen wrote: > >> Hope that will help to clarify. > > > > Yes that helps, maybe we should add these bits in code and changelog.. > > :)I will update the comments and commit message in a V2 in this way > > > > And how does this impact non cyclic case where N descrip

Re: [PATCH] dmaengine: stm32-dma: fix residue calculation in stm32-dma

2019-04-30 Thread Arnaud Pouliquen
On 4/30/19 10:22 AM, Vinod Koul wrote: > On 29-04-19, 16:52, Arnaud Pouliquen wrote: >> >> >> On 4/29/19 7:13 AM, Vinod Koul wrote: >>> On 26-04-19, 15:41, Arnaud Pouliquen wrote: >> During residue calculation. the DMA can switch to the next sg. When >> this race condition occurs, the re

Re: [PATCH] dmaengine: stm32-dma: fix residue calculation in stm32-dma

2019-04-30 Thread Vinod Koul
On 29-04-19, 16:52, Arnaud Pouliquen wrote: > > > On 4/29/19 7:13 AM, Vinod Koul wrote: > > On 26-04-19, 15:41, Arnaud Pouliquen wrote: > During residue calculation. the DMA can switch to the next sg. When > this race condition occurs, the residue returned value is not valid. > Ind

Re: [PATCH] dmaengine: stm32-dma: fix residue calculation in stm32-dma

2019-04-29 Thread Arnaud Pouliquen
On 4/29/19 7:13 AM, Vinod Koul wrote: > On 26-04-19, 15:41, Arnaud Pouliquen wrote: During residue calculation. the DMA can switch to the next sg. When this race condition occurs, the residue returned value is not valid. Indeed the position in the sg returned by the hardware is th

Re: [PATCH] dmaengine: stm32-dma: fix residue calculation in stm32-dma

2019-04-28 Thread Vinod Koul
On 26-04-19, 15:41, Arnaud Pouliquen wrote: > >> During residue calculation. the DMA can switch to the next sg. When > >> this race condition occurs, the residue returned value is not valid. > >> Indeed the position in the sg returned by the hardware is the position > >> of the next sg, not the cur

Re: [PATCH] dmaengine: stm32-dma: fix residue calculation in stm32-dma

2019-04-26 Thread Arnaud Pouliquen
Hi Vinod On 4/26/19 2:17 PM, Vinod Koul wrote: > Hi Arnaud, > > Sorry for delay in review, the conference travel/vacation plan delayed > this. no problem, just a rememder to be sure that you not missed it in the patch stream. > > On 27-03-19, 13:21, Arnaud Pouliquen wrote: >> During residue cal

Re: [PATCH] dmaengine: stm32-dma: fix residue calculation in stm32-dma

2019-04-26 Thread Vinod Koul
Hi Arnaud, Sorry for delay in review, the conference travel/vacation plan delayed this. On 27-03-19, 13:21, Arnaud Pouliquen wrote: > During residue calculation. the DMA can switch to the next sg. When > this race condition occurs, the residue returned value is not valid. > Indeed the position in

Re: [PATCH] dmaengine: stm32-dma: fix residue calculation in stm32-dma

2019-04-24 Thread Pierre Yves MORDRET
Hello Reviewed-by: Pierre-Yves MORDRET Thanks On 4/23/19 5:18 PM, Arnaud Pouliquen wrote: > Hello Vinod, > > Just a gentle reminder, if you could take a moment to review this patch. > FYI, the patch has already been internally reviewed by Pierre Yves > mordret... > His sign-off is in the commi

Re: [PATCH] dmaengine: stm32-dma: fix residue calculation in stm32-dma

2019-04-23 Thread Arnaud Pouliquen
Hello Vinod, Just a gentle reminder, if you could take a moment to review this patch. FYI, the patch has already been internally reviewed by Pierre Yves mordret... His sign-off is in the commit message. Thanks, Arnaud On 3/27/19 1:21 PM, Arnaud Pouliquen wrote: > During residue calculation. th