Re: [PATCH] drivers: android: Restructure code in lowmemorykiller

2013-01-31 Thread Greg Kroah-Hartman
On Fri, Feb 01, 2013 at 12:48:16AM +0200, Stratos Karafotis wrote: > On 02/01/2013 12:25 AM, Greg Kroah-Hartman wrote: > >Given that no one is working on it, why does it need to be maintained > >easier? :) > > Thanks for your immediate response. > I was thinking to work on this driver. Is it goin

Re: [PATCH] drivers: android: Restructure code in lowmemorykiller

2013-01-31 Thread Dan Carpenter
On Fri, Feb 01, 2013 at 12:48:16AM +0200, Stratos Karafotis wrote: > I will fix it. I don't know the status of this driver. But in general the patch should have been divided up into smaller changes and sent as a patchset. It creates a bunch of messy new globals where it would have been cleaner t

Re: [PATCH] drivers: android: Restructure code in lowmemorykiller

2013-01-31 Thread Stratos Karafotis
On 02/01/2013 12:25 AM, Greg Kroah-Hartman wrote: Given that no one is working on it, why does it need to be maintained easier? :) Thanks for your immediate response. I was thinking to work on this driver. Is it going to be obsolete or something? Why create a .h file? Who needs it? Only

Re: [PATCH] drivers: android: Restructure code in lowmemorykiller

2013-01-31 Thread Greg Kroah-Hartman
On Thu, Jan 31, 2013 at 11:32:06PM +0200, Stratos Karafotis wrote: > This patch restructures code for better readability and easier > maintenance. Given that no one is working on it, why does it need to be maintained easier? :) > Also introduces lowmemorykiller.h header file. Why create a .h fi