Re: [PATCH] drivers: extcon: Add support for ptn5150

2019-01-21 Thread Vijai Kumar K
On Tue, Jan 22, 2019 at 03:20:09PM +0900, Chanwoo Choi wrote: > Hi Vijai, > > This patch looks better. But theare are comments about code clean. > I added the comments. > Thanks. And Thank you for reviewing it Chanwoo. Please find my inline comments. I will rebase, implement the review comments

Re: [PATCH] drivers: extcon: Add support for ptn5150

2019-01-21 Thread Vijai Kumar K
On Tue, Jan 22, 2019 at 02:27:51PM +0900, Chanwoo Choi wrote: > Hi Vijai, > > On 19. 1. 22. 오후 1:42, Vijai Kumar K wrote: > > Hi Chanwoo Choi, > > > > This is the first time I am sending a driver to LKML. I have a few doubts. > > Can > > you please clarify them when you are free? > > > > 1. I h

Re: Re: [PATCH] drivers: extcon: Add support for ptn5150

2019-01-21 Thread Vijai Kumar K
On Tue, Jan 22, 2019 at 01:57:46PM +0900, MyungJoo Ham wrote: > >Hi Chanwoo Choi, > > > >This is the first time I am sending a driver to LKML. I have a few doubts. > >Can > >you please clarify them when you are free? > > Although I'm not Chanwoo, but a guy who's about 50ft away from his cubicle,

Re: [PATCH] drivers: extcon: Add support for ptn5150

2019-01-21 Thread Chanwoo Choi
Hi Vijai, This patch looks better. But theare are comments about code clean. I added the comments. On 19. 1. 21. 오후 6:09, Vijai Kumar K wrote: > PTN5150A is a small thin low power CC Logic chip supporting > the USB Type-C connector application with Configurationn Channel(CC) > control logic detec

Re: [PATCH] drivers: extcon: Add support for ptn5150

2019-01-21 Thread Chanwoo Choi
Hi Vijai, On 19. 1. 22. 오후 1:42, Vijai Kumar K wrote: > Hi Chanwoo Choi, > > This is the first time I am sending a driver to LKML. I have a few doubts. Can > you please clarify them when you are free? > > 1. I have developed and tested this patch on 4.14.89 kernel. When trying to > mainline the

RE: Re: [PATCH] drivers: extcon: Add support for ptn5150

2019-01-21 Thread MyungJoo Ham
>Hi Chanwoo Choi, > >This is the first time I am sending a driver to LKML. I have a few doubts. Can >you please clarify them when you are free? Although I'm not Chanwoo, but a guy who's about 50ft away from his cubicle, as he appears to be busy today... :) > >1. I have developed and tested this p

Re: [PATCH] drivers: extcon: Add support for ptn5150

2019-01-21 Thread Vijai Kumar K
Hi Chanwoo Choi, This is the first time I am sending a driver to LKML. I have a few doubts. Can you please clarify them when you are free? 1. I have developed and tested this patch on 4.14.89 kernel. When trying to mainline the driver should I rebase and send the patch on top of current tree(v5

Re: [PATCH] drivers: extcon: Add support for ptn5150

2019-01-21 Thread kbuild test robot
Hi Vijai, Thank you for the patch! Yet something to improve: [auto build test ERROR on chanwoo-extcon/extcon-next] [also build test ERROR on v5.0-rc2] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/com