Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-12-08 Thread Jiaxun Yang
于 2020年12月9日 GMT+08:00 上午6:28:11, Roman Kiryanov 写到: >On Sat, Nov 14, 2020 at 1:48 AM Jiaxun Yang wrote: >> Thus I do think it shouldn't be retired as for now. If nobody comes in >> I'd also willing to maintain > >Hi Jiaxun and Hancai, > >I sent a patch to add you to MAINTAINERS for

Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-12-08 Thread Roman Kiryanov
On Sat, Nov 14, 2020 at 1:48 AM Jiaxun Yang wrote: > Thus I do think it shouldn't be retired as for now. If nobody comes in > I'd also willing to maintain Hi Jiaxun and Hancai, I sent a patch to add you to MAINTAINERS for goldfish-rtc. Could you please ack there? Regards, Roman.

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-14 Thread Huacai Chen
; > From: "Greg KH"; > > Date: Sat, Nov 14, 2020 07:43 AM > > To: "Roman Kiryanov"; > > Cc: "chenhc"; "Paul > > Walmsley"; "LKML"; > > "Lingfeng Yang"; "Rob Herring"; > > Subject: R

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-14 Thread Roman Kiryanov
we should keep it in kernel. > > Huacai > > > -- Original -- > From: "Greg KH"; > Date: Sat, Nov 14, 2020 07:43 AM > To: "Roman Kiryanov"; > Cc: "chenhc"; "Paul Walmsley"; > "LKML"; &

Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-14 Thread Roman Kiryanov
> > Thus I do think it shouldn't be retired as for now. If nobody comes in I'd > > also willing to maintain > > it. > > Ok, can someone submit a patch to update the MAINTAINERS file for this > so we know who to route issues to over time? I will send a patch to update MAINTAINERS for goldfish-rtc.

Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-14 Thread Greg KH
On Sat, Nov 14, 2020 at 05:47:47PM +0800, Jiaxun Yang wrote: > > > 在 2020/11/14 下午4:15, Greg KH 写道: > > + qemu-riscv list and QEMU device maintainers of goldfish_rtc > > > On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote: > > > Hi, All, > > > > > > Goldfish RTC works well on MIPS, and QEMU

Re: Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-14 Thread Jiaxun Yang
在 2020/11/14 下午4:15, Greg KH 写道: + qemu-riscv list and QEMU device maintainers of goldfish_rtc On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote: Hi, All, Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish as well, so I think we should keep it in kernel. But does

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-14 Thread Huacai Chen
Hi, Greg, On Sat, Nov 14, 2020 at 4:16 PM Greg KH wrote: > > On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote: > > Hi, All, > > > > Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish > > as well, so I think we should keep it in kernel. > > And more importantly, if you

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-14 Thread Greg KH
On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote: > Hi, All, > > Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish > as well, so I think we should keep it in kernel. And more importantly, if you rely on this, are you willing to maintain it? thanks, gre gk-h

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-14 Thread Greg KH
On Sat, Nov 14, 2020 at 04:06:24PM +0800, 陈华才 wrote: > Hi, All, > > Goldfish RTC works well on MIPS, and QEMU RISC-V emulator use Goldfish > as well, so I think we should keep it in kernel. But does anyone actually use it for anything? Having something in qemu is nice, but not required if it

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-13 Thread Greg KH
On Fri, Nov 13, 2020 at 03:36:49PM -0800, Roman Kiryanov wrote: > +Greg KH > > On Fri, Nov 13, 2020 at 2:02 PM Roman Kiryanov wrote: > > > > Hi Hancai, > > > > I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts > > which > > refers to goldfish-rtc in

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-13 Thread Roman Kiryanov
+Greg KH On Fri, Nov 13, 2020 at 2:02 PM Roman Kiryanov wrote: > > Hi Hancai, > > I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts > which > refers to goldfish-rtc in 39c1485c8baa47aa20caefc1ec0a3410fbad6c81. > We (Android Studio Emulator aka "goldfish") do not support

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-13 Thread Roman Kiryanov
Hi Hancai, I see you added /arch/mips/boot/dts/loongson/loongson64v_4core_virtio.dts which refers to goldfish-rtc in 39c1485c8baa47aa20caefc1ec0a3410fbad6c81. We (Android Studio Emulator aka "goldfish") do not support MIPS anymore. Do you know if goldfish-rtc still works and is assumed to be

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-13 Thread Rob Herring
On Fri, Nov 13, 2020 at 3:13 PM Roman Kiryanov wrote: > > Hi Rob, thank you for looking into this. > > On Fri, Nov 13, 2020 at 1:07 PM Rob Herring wrote: > > > > On Fri, Nov 13, 2020 at 12:52:33PM -0800, r...@google.com wrote: > > > From: Roman Kiryanov > > > > > > The only user of

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-13 Thread Roman Kiryanov
Hi Rob, thank you for looking into this. On Fri, Nov 13, 2020 at 1:07 PM Rob Herring wrote: > > On Fri, Nov 13, 2020 at 12:52:33PM -0800, r...@google.com wrote: > > From: Roman Kiryanov > > > > The only user of RTC_DRV_GOLDFISH is > > the MIPS flavor of Android Studio Emulator > > (goldfish)

Re: [PATCH] drivers: rtc: retire RTC_DRV_GOLDFISH

2020-11-13 Thread Rob Herring
On Fri, Nov 13, 2020 at 12:52:33PM -0800, r...@google.com wrote: > From: Roman Kiryanov > > The only user of RTC_DRV_GOLDFISH is > the MIPS flavor of Android Studio Emulator > (goldfish) which should be also retired. > > Signed-off-by: Roman Kiryanov > --- > arch/riscv/Kconfig.socs| 1 -