Re: [PATCH] drm/amdkfd: Put ACPI table after using it

2020-07-30 Thread Hanjun Guo
On 2020/7/31 10:41, Felix Kuehling wrote: Hi Hanjun, Sorry for the late reply. Thank you for the patch and the explanation. This seems to have been broken since the first version of KFD in 2014. See one suggestion inline. Am 2020-07-22 um 5:48 a.m. schrieb Hanjun Guo: The acpi_get_table() sho

Re: [PATCH] drm/amdkfd: Put ACPI table after using it

2020-07-30 Thread Felix Kuehling
Hi Hanjun, Sorry for the late reply. Thank you for the patch and the explanation. This seems to have been broken since the first version of KFD in 2014. See one suggestion inline. Am 2020-07-22 um 5:48 a.m. schrieb Hanjun Guo: > The acpi_get_table() should be coupled with acpi_put_table() if > t

Re: [PATCH] drm/amdkfd: Put ACPI table after using it

2020-07-22 Thread Markus Elfring
… > and in kfd_create_vcrat_image_cpu(), the acpi_table is only used to > get the OEM info, so those table mappings need to be release after … 1. Please avoid a typo for this change description. 2. An imperative wording can be preferred here, can't it? 3. Will the tag “Fixes” become helpful for