Re: Re: [PATCH] ext4: Fix memleak in add_new_gdb

2020-08-28 Thread dinghao . liu
> On Thu 27-08-20 14:28:43, Dinghao Liu wrote: > > When ext4_journal_get_write_access() fails, we should release > > n_group_desc, iloc.bh, dind and gdb_bh to prevent memleak. > > It's the same when ext4_handle_dirty_super() fails, but we > > don't need to release dind here because it has been

Re: [PATCH] ext4: Fix memleak in add_new_gdb

2020-08-28 Thread Jan Kara
On Thu 27-08-20 14:28:43, Dinghao Liu wrote: > When ext4_journal_get_write_access() fails, we should release > n_group_desc, iloc.bh, dind and gdb_bh to prevent memleak. > It's the same when ext4_handle_dirty_super() fails, but we > don't need to release dind here because it has been released >