Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-06-01 Thread Maxime Ripard
On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: > Hi! > > > > > single DT, you don't even use that property in your driver, and now > > > > that you realise you meant something else, you want the code that > > > > > > not Pali, Sebastian. > > > > > > > actually parse the *right*

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-06-01 Thread Pavel Machek
On Mon 2015-06-01 11:49:19, Maxime Ripard wrote: > On Sat, May 30, 2015 at 12:14:30PM +0200, Pavel Machek wrote: > > Well... the driver was not broken... before you did "cleanup" that did > > two functional changes. And yes, the dts should be fixed, but that > > does not make your "cleanup" good.

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-06-01 Thread Maxime Ripard
On Sat, May 30, 2015 at 12:14:30PM +0200, Pavel Machek wrote: > Well... the driver was not broken... before you did "cleanup" that did > two functional changes. And yes, the dts should be fixed, but that > does not make your "cleanup" good. Whether it's good or not is arguable, and it really

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-06-01 Thread Maxime Ripard
On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: Hi! single DT, you don't even use that property in your driver, and now that you realise you meant something else, you want the code that not Pali, Sebastian. actually parse the *right* property and does the

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-06-01 Thread Maxime Ripard
On Sat, May 30, 2015 at 12:14:30PM +0200, Pavel Machek wrote: Well... the driver was not broken... before you did cleanup that did two functional changes. And yes, the dts should be fixed, but that does not make your cleanup good. Whether it's good or not is arguable, and it really boils down

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-06-01 Thread Pavel Machek
On Mon 2015-06-01 11:49:19, Maxime Ripard wrote: On Sat, May 30, 2015 at 12:14:30PM +0200, Pavel Machek wrote: Well... the driver was not broken... before you did cleanup that did two functional changes. And yes, the dts should be fixed, but that does not make your cleanup good. Whether

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-30 Thread Pavel Machek
On Fri 2015-05-29 22:03:06, Maxime Ripard wrote: > On Fri, May 29, 2015 at 02:49:55PM -0500, Felipe Balbi wrote: > > Hi, > > > > On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: > > > Fix dts to match what the Linux kernel expects. This works around > > > touchscreen problems in 4.1

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-30 Thread Pavel Machek
On Fri 2015-05-29 22:03:06, Maxime Ripard wrote: On Fri, May 29, 2015 at 02:49:55PM -0500, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel expects. This works around touchscreen problems in 4.1 linux on

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Sebastian Reichel
Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: > Fix dts to match what the Linux kernel expects. This works around > touchscreen problems in 4.1 linux on Nokia n900. > > Signed-off-by: Pavel Machek > > diff --git

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 11:02:59PM +0200, Pavel Machek wrote: > On Fri 2015-05-29 13:48:47, Dmitry Torokhov wrote: > > On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: > > > Hi! > > > > > > > > > single DT, you don't even use that property in your driver, and now > > > > > > that you

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Pavel Machek
On Fri 2015-05-29 13:48:47, Dmitry Torokhov wrote: > On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: > > Hi! > > > > > > > single DT, you don't even use that property in your driver, and now > > > > > that you realise you meant something else, you want the code that > > > > > > > >

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: > Hi! > > > > > single DT, you don't even use that property in your driver, and now > > > > that you realise you meant something else, you want the code that > > > > > > not Pali, Sebastian. > > > > > > > actually parse the *right*

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Pavel Machek
Hi! > > > single DT, you don't even use that property in your driver, and now > > > that you realise you meant something else, you want the code that > > > > not Pali, Sebastian. > > > > > actually parse the *right* property and does the right thing, that all > > > other DT agree (and depend

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Pavel Machek
> > > So, because this has been wrongly documented for so long, we should > > > support both bindings. Sure, deprecate touchscreen-max-[xy], but they > > > must still be supported, IMO. > > > > This property has never been anything but a typo in a documentation of > > a single driver. > > > >

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 03:21:23PM -0500, Felipe Balbi wrote: > On Fri, May 29, 2015 at 10:17:45PM +0200, Maxime Ripard wrote: > > On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: > > > On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Fri, May 29, 2015

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Felipe Balbi
On Fri, May 29, 2015 at 10:17:45PM +0200, Maxime Ripard wrote: > On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: > > On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: > > > Hi, > > > > > > On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: > > > > Fix dts to match what the

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: > On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: > > Hi, > > > > On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: > > > Fix dts to match what the Linux kernel expects. This works around > > > touchscreen problems in 4.1

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Maxime Ripard
On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: > On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: > > Hi, > > > > On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: > > > Fix dts to match what the Linux kernel expects. This works around > > > touchscreen problems in 4.1

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Tony Lindgren
* Maxime Ripard [150529 13:06]: > On Fri, May 29, 2015 at 02:49:55PM -0500, Felipe Balbi wrote: > > Hi, > > > > On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: > > > Fix dts to match what the Linux kernel expects. This works around > > > touchscreen problems in 4.1 linux on Nokia

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Maxime Ripard
On Fri, May 29, 2015 at 02:49:55PM -0500, Felipe Balbi wrote: > Hi, > > On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: > > Fix dts to match what the Linux kernel expects. This works around > > touchscreen problems in 4.1 linux on Nokia n900. > > > > Signed-off-by: Pavel Machek

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Pavel Machek
On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: > Hi, > > On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: > > Fix dts to match what the Linux kernel expects. This works around > > touchscreen problems in 4.1 linux on Nokia n900. > > > > Signed-off-by: Pavel Machek > > > >

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Felipe Balbi
Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: > Fix dts to match what the Linux kernel expects. This works around > touchscreen problems in 4.1 linux on Nokia n900. > > Signed-off-by: Pavel Machek > > diff --git

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Sebastian Reichel
Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel expects. This works around touchscreen problems in 4.1 linux on Nokia n900. Signed-off-by: Pavel Machek pa...@ucw.cz diff --git

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: Hi! single DT, you don't even use that property in your driver, and now that you realise you meant something else, you want the code that not Pali, Sebastian. actually parse the *right* property and does the

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Pavel Machek
On Fri 2015-05-29 13:48:47, Dmitry Torokhov wrote: On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: Hi! single DT, you don't even use that property in your driver, and now that you realise you meant something else, you want the code that not Pali, Sebastian.

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Felipe Balbi
Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel expects. This works around touchscreen problems in 4.1 linux on Nokia n900. Signed-off-by: Pavel Machek pa...@ucw.cz diff --git

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Pavel Machek
On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel expects. This works around touchscreen problems in 4.1 linux on Nokia n900. Signed-off-by: Pavel Machek pa...@ucw.cz diff

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Maxime Ripard
On Fri, May 29, 2015 at 02:49:55PM -0500, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel expects. This works around touchscreen problems in 4.1 linux on Nokia n900. Signed-off-by: Pavel Machek

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Tony Lindgren
* Maxime Ripard maxime.rip...@free-electrons.com [150529 13:06]: On Fri, May 29, 2015 at 02:49:55PM -0500, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel expects. This works around touchscreen problems in

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Felipe Balbi
On Fri, May 29, 2015 at 10:17:45PM +0200, Maxime Ripard wrote: On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Pavel Machek
Hi! single DT, you don't even use that property in your driver, and now that you realise you meant something else, you want the code that not Pali, Sebastian. actually parse the *right* property and does the right thing, that all other DT agree (and depend on) to be reverted?

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Maxime Ripard
On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel expects. This works around touchscreen problems in 4.1 linux on Nokia

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote: Fix dts to match what the Linux kernel expects. This works around touchscreen problems in 4.1 linux on Nokia

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 03:21:23PM -0500, Felipe Balbi wrote: On Fri, May 29, 2015 at 10:17:45PM +0200, Maxime Ripard wrote: On Fri, May 29, 2015 at 09:56:29PM +0200, Pavel Machek wrote: On Fri 2015-05-29 14:49:55, Felipe Balbi wrote: Hi, On Fri, May 29, 2015 at 09:32:11PM

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Pavel Machek
So, because this has been wrongly documented for so long, we should support both bindings. Sure, deprecate touchscreen-max-[xy], but they must still be supported, IMO. This property has never been anything but a typo in a documentation of a single driver. Feel free to fix

Re: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900

2015-05-29 Thread Dmitry Torokhov
On Fri, May 29, 2015 at 11:02:59PM +0200, Pavel Machek wrote: On Fri 2015-05-29 13:48:47, Dmitry Torokhov wrote: On Fri, May 29, 2015 at 10:34:56PM +0200, Pavel Machek wrote: Hi! single DT, you don't even use that property in your driver, and now that you realise you meant