Re: [PATCH] flush icache before set_pte on ia64 take3

2007-07-26 Thread Zoltan Menyhart
KAMEZAWA Hiroyuki wrote: Thank you for advise. Hmm..how about this ? == /* * synchronize icache and dcache if the hardware doesn't do it automatically * and the page is executable. */ static inline arch_sync_icache_dcache(pte_t pte, page) { } Why not? I just wanted to see if you chang

Re: [PATCH] flush icache before set_pte on ia64 take3

2007-07-26 Thread KAMEZAWA Hiroyuki
On Thu, 26 Jul 2007 17:13:52 +0200 Zoltan Menyhart <[EMAIL PROTECTED]> wrote: > I can agree: > - lazy_mmu_prot_update() is not the right place for a flush > - to flush I-cache before inserting PTE (at least for the > machines with physical address tagged caches) > > Can we have a separate, spec

Re: [PATCH] flush icache before set_pte on ia64 take3

2007-07-26 Thread Zoltan Menyhart
I do not think changing the semantics of flush_cache_page() is a good idea. Please have a look at Documentation/cachetlb.txt. This is for virtual address tagged caches. The doc. does not say much about flush_icache_page(). It is used in: install_page(): can release any previously existing mappin

Re: [PATCH] flush icache before set_pte on ia64 take3

2007-07-26 Thread KAMEZAWA Hiroyuki
On Thu, 26 Jul 2007 17:13:23 +0900 KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote: > - lazy_mmu_prot_update() checked pte's executable bit. This was because old >Linux's anon page has executable bit. Current kernel doesn't set executable >bit on anonymous pages. > Linux's anon page had VM_EX