Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

2018-08-01 Thread Al Viro
On Thu, Aug 02, 2018 at 10:04:34AM +0800, zhong jiang wrote: > It is unncessary to use double test for a expression. so just > remove one of them. ... except when something in that expression might have side effects, that is.

Re: [PATCH] fs/binfmt_elf_fdpic: remove redundant condition check in writenote

2018-08-01 Thread zhong jiang
plese ingore it. On 2018/8/2 10:04, zhong jiang wrote: > It is unncessary to use double test for a expression. so just > remove one of them. > > Signed-off-by: zhong jiang > --- > fs/binfmt_elf_fdpic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/binfmt_elf_fdpic.