Re: [PATCH] fs/ext4/super.c: Let 'counters' switched by SMP

2014-07-23 Thread David Rientjes
On Mon, 21 Jul 2014, Theodore Ts'o wrote: > Right, sorry, I'm currently in vacation in Rome, and the network > connection was really lousy here now that I'm no longer at the ACACES > summer school in Fiuggi. (Also, now that I'm no longer actually > teaching, I've beeen trying to actually do the d

Re: [PATCH] fs/ext4/super.c: Let 'counters' switched by SMP

2014-07-21 Thread Theodore Ts'o
On Mon, Jul 21, 2014 at 10:40:02AM -0700, Olof Johansson wrote: > > I'll respin the "ext4: rearrange initialization to fix EXT4FS_DEBUG" > > commit to include this fix and give you credit in the commit logs for > > pointing out this issue. > > Friendly ping, since all !SMP builds in -next seem to

Re: [PATCH] fs/ext4/super.c: Let 'counters' switched by SMP

2014-07-21 Thread Olof Johansson
Hi Ted, On Tue, Jul 15, 2014 at 2:31 AM, Theodore Ts'o wrote: > On Tue, Jul 15, 2014 at 09:05:29AM +0800, Chen Gang wrote: >> When SMP is disabled, 'struct percpu_counter' has no 'counters' member, >> so need skip it when in !SMP. >> >> The related git commit: >> >> "feab139 ext4: rearrange ini

Re: [PATCH] fs/ext4/super.c: Let 'counters' switched by SMP

2014-07-15 Thread Chen Gang
On 07/15/2014 05:31 PM, Theodore Ts'o wrote: > On Tue, Jul 15, 2014 at 09:05:29AM +0800, Chen Gang wrote: >> When SMP is disabled, 'struct percpu_counter' has no 'counters' member, >> so need skip it when in !SMP. >> >> The related git commit: >> >> "feab139 ext4: rearrange initialization to fix

Re: [PATCH] fs/ext4/super.c: Let 'counters' switched by SMP

2014-07-15 Thread Theodore Ts'o
On Tue, Jul 15, 2014 at 09:05:29AM +0800, Chen Gang wrote: > When SMP is disabled, 'struct percpu_counter' has no 'counters' member, > so need skip it when in !SMP. > > The related git commit: > > "feab139 ext4: rearrange initialization to fix EXT4FS_DEBUG". > > The related error (with allmodc