Re: [PATCH] fs: Preserve error code in get_empty_filp()

2013-02-21 Thread Theodore Ts'o
> > A little bit of context for this change. We at Google work on a test > > framework that shows how kernel behaves under memory pressure. In the > > codepath that I am fixing the syscalls return ENFILE error, but in > > fact the correct error would be ENOMEM. get_empty_filp() should > > preserve

Re: [PATCH] fs: Preserve error code in get_empty_filp()

2013-02-14 Thread Al Viro
On Fri, Oct 05, 2012 at 11:16:12AM -0700, Anatol Pomozov wrote: > Hi, AlViro > > Is any reason why this change is ignored? For me it looks like a > straightforward bugfix. > > A little bit of context for this change. We at Google work on a test > framework that shows how kernel behaves under memo

Re: [PATCH] fs: Preserve error code in get_empty_filp()

2012-10-05 Thread Theodore Ts'o
On Fri, Oct 05, 2012 at 11:16:12AM -0700, Anatol Pomozov wrote: > Hi, AlViro > > Is any reason why this change is ignored? For me it looks like a > straightforward bugfix. > > A little bit of context for this change. We at Google work on a test > framework that shows how kernel behaves under memo

Re: [PATCH] fs: Preserve error code in get_empty_filp()

2012-10-05 Thread Anatol Pomozov
Hi, AlViro Is any reason why this change is ignored? For me it looks like a straightforward bugfix. A little bit of context for this change. We at Google work on a test framework that shows how kernel behaves under memory pressure. In the codepath that I am fixing the syscalls return ENFILE error

Re: [PATCH] fs: Preserve error code in get_empty_filp()

2012-09-04 Thread Anatol Pomozov
Hi, Al Do you have some time to review this change? Does it look good? On Thu, Aug 2, 2012 at 5:47 PM, Anatol Pomozov wrote: > Allocating a file structure in function get_empty_filp() might fail because > of several reasons: > - not enough memory for file structures > - operation is not allowe

Re: [PATCH] fs: Preserve error code in get_empty_filp()

2012-08-21 Thread Anatol Pomozov
Hi On Tue, Aug 21, 2012 at 3:06 AM, Jan Engelhardt wrote: > > > On Wednesday 2012-08-01 20:19, anatol.pomo...@gmail.com wrote: > >Allocating a file structure in function get_empty_filp() might fail > > because > >of several reasons: > > - not enough memory for file structures > > - operation is n

Re: [PATCH] fs: Preserve error code in get_empty_filp()

2012-08-21 Thread Jan Engelhardt
On Wednesday 2012-08-01 20:19, anatol.pomo...@gmail.com wrote: >Allocating a file structure in function get_empty_filp() might fail because >of several reasons: > - not enough memory for file structures > - operation is not allowed > - user is over its limit > >Currently the function returns NULL

Re: [PATCH] fs: Preserve error code in get_empty_filp()

2012-08-02 Thread Anatol Pomozov
Hi Current HEAD contains conflicting changes in fs/pipe.c. I am going to rebase my patch and resend it. On Wed, Aug 1, 2012 at 11:34 AM, wrote: > From: Anatol Pomazau > > Allocating a file structure in function get_empty_filp() might fail because > of several reasons: > - not enough memory fo