Re: [PATCH] fs : reorder some 'struct inode' fields to speedup i_size manipulations

2006-11-28 Thread Eric Dumazet
Andrew Morton a écrit : This all depends on the offset of the inode, and you don't know what that is. offsetof(ext3_inode_info, vfs_inode) != offsetof(nfs_inode, vfs_inode), etc. Doh... yes you are absolutly right :) I feel dumb now :( - To unsubscribe from this list: send the line "unsubscr

Re: [PATCH] fs : reorder some 'struct inode' fields to speedup i_size manipulations

2006-11-27 Thread Andrew Morton
On Mon, 27 Nov 2006 22:52:04 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > > I didn't understand that paragraph at all, really, so I took it out. > > > > At present an i_size change will dirty one, two or three cachelines, most > > likely one or two. > > > > After your patch an i_size change w

Re: [PATCH] fs : reorder some 'struct inode' fields to speedup i_size manipulations

2006-11-27 Thread Eric Dumazet
Andrew Morton a écrit : On Thu, 23 Nov 2006 11:57:29 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: On 32bits SMP platforms, 64bits i_size is protected by a seqcount (i_size_seqcount). When i_size is read or written, i_size_seqcount is read/written as well, so it make sense to group these two

Re: [PATCH] fs : reorder some 'struct inode' fields to speedup i_size manipulations

2006-11-27 Thread Andrew Morton
On Thu, 23 Nov 2006 11:57:29 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > On 32bits SMP platforms, 64bits i_size is protected by a seqcount > (i_size_seqcount). > > When i_size is read or written, i_size_seqcount is read/written as well, so > it > make sense to group these two fields togeth