Re: [PATCH] gma500: clean up an excessive and confusing helper

2016-02-08 Thread Daniel Vetter
On Mon, Feb 01, 2016 at 09:11:51AM +0100, Patrik Jakobsson wrote: > On Fri, Jan 29, 2016 at 8:37 PM, Alan wrote: > > From: Alan Cox > > > > This is a left over from the great clean ups in the past. It's confusing as > > it returns an int, yet has one caller that never uses it. The caller already

Re: [PATCH] gma500: clean up an excessive and confusing helper

2016-02-01 Thread Patrik Jakobsson
On Fri, Jan 29, 2016 at 8:37 PM, Alan wrote: > From: Alan Cox > > This is a left over from the great clean ups in the past. It's confusing as > it returns an int, yet has one caller that never uses it. The caller already > has all the right private variables local so the entire function can be >