Re: [PATCH] huegtlbfs: fix page leak during migration of file pages

2019-02-11 Thread Mike Kravetz
On 2/11/19 6:24 PM, Naoya Horiguchi wrote: > On Mon, Feb 11, 2019 at 03:06:27PM -0800, Mike Kravetz wrote: >> While looking at this, I think there is another issue. When a hugetlb >> page is migrated, we do not migrate the 'page_huge_active' state of the >> page. That should be moved as the page

Re: [PATCH] huegtlbfs: fix page leak during migration of file pages

2019-02-11 Thread Naoya Horiguchi
On Mon, Feb 11, 2019 at 03:06:27PM -0800, Mike Kravetz wrote: > On 2/7/19 11:31 PM, Naoya Horiguchi wrote: > > On Thu, Feb 07, 2019 at 09:50:30PM -0800, Mike Kravetz wrote: > >> On 2/7/19 6:31 PM, Naoya Horiguchi wrote: > >>> On Thu, Feb 07, 2019 at 10:50:55AM -0800, Mike Kravetz wrote: > On 1

Re: [PATCH] huegtlbfs: fix page leak during migration of file pages

2019-02-11 Thread Mike Kravetz
On 2/7/19 11:31 PM, Naoya Horiguchi wrote: > On Thu, Feb 07, 2019 at 09:50:30PM -0800, Mike Kravetz wrote: >> On 2/7/19 6:31 PM, Naoya Horiguchi wrote: >>> On Thu, Feb 07, 2019 at 10:50:55AM -0800, Mike Kravetz wrote: On 1/30/19 1:14 PM, Mike Kravetz wrote: > +++ b/fs/hugetlbfs/inode.c >>>

Re: [PATCH] huegtlbfs: fix page leak during migration of file pages

2019-02-07 Thread Naoya Horiguchi
On Thu, Feb 07, 2019 at 09:50:30PM -0800, Mike Kravetz wrote: > On 2/7/19 6:31 PM, Naoya Horiguchi wrote: > > On Thu, Feb 07, 2019 at 10:50:55AM -0800, Mike Kravetz wrote: > >> On 1/30/19 1:14 PM, Mike Kravetz wrote: > >>> +++ b/fs/hugetlbfs/inode.c > >>> @@ -859,6 +859,16 @@ static int hugetlbfs_m

Re: [PATCH] huegtlbfs: fix page leak during migration of file pages

2019-02-07 Thread Mike Kravetz
On 2/7/19 6:31 PM, Naoya Horiguchi wrote: > On Thu, Feb 07, 2019 at 10:50:55AM -0800, Mike Kravetz wrote: >> On 1/30/19 1:14 PM, Mike Kravetz wrote: >>> +++ b/fs/hugetlbfs/inode.c >>> @@ -859,6 +859,16 @@ static int hugetlbfs_migrate_page(struct address_space >>> *mapping, >>> rc = migrate_hug

Re: [PATCH] huegtlbfs: fix page leak during migration of file pages

2019-02-07 Thread Naoya Horiguchi
On Thu, Feb 07, 2019 at 10:50:55AM -0800, Mike Kravetz wrote: > On 1/30/19 1:14 PM, Mike Kravetz wrote: > > Files can be created and mapped in an explicitly mounted hugetlbfs > > filesystem. If pages in such files are migrated, the filesystem > > usage will not be decremented for the associated pa

Re: [PATCH] huegtlbfs: fix page leak during migration of file pages

2019-02-07 Thread Mike Kravetz
On 1/30/19 1:14 PM, Mike Kravetz wrote: > Files can be created and mapped in an explicitly mounted hugetlbfs > filesystem. If pages in such files are migrated, the filesystem > usage will not be decremented for the associated pages. This can > result in mmap or page allocation failures as it appe

Re: [PATCH] huegtlbfs: fix page leak during migration of file pages

2019-02-01 Thread Mike Kravetz
On 1/31/19 6:12 AM, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 290408d4a250 hugetlb: hugepage migration core. > > The bot has tested the following trees: v4.20.5, v4.19.18, v4.14.96, > v4.9.15