Re: [PATCH] i2c: davinci: Add block read functionality for IPMI

2014-06-02 Thread Murali Karicheri
On 5/22/2014 6:51 AM, Sekhar Nori wrote: On Friday 02 May 2014 12:19 AM, Murali Karicheri wrote: Intelligent Plaform Management Interface (IPMI) requires I2C driver to support block read, where the first byte received from slave is the length of following data:- Added length check if the read

Re: [PATCH] i2c: davinci: Add block read functionality for IPMI

2014-06-02 Thread Murali Karicheri
On 5/22/2014 5:00 AM, Wolfram Sang wrote: Hi, thanks for the patch. +/* capabilities */ +#define I2C_CAPABILITIES (I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | \ +I2C_FUNC_SMBUS_READ_BLOCK_DATA) I don't see the need for a seperate define. + struct davinci_i2c_d

Re: [PATCH] i2c: davinci: Add block read functionality for IPMI

2014-05-22 Thread Sekhar Nori
On Friday 02 May 2014 12:19 AM, Murali Karicheri wrote: > Intelligent Plaform Management Interface (IPMI) requires I2C driver > to support block read, where the first byte received from slave is > the length of following data:- > Added length check if the read type is block read (I2C_M_RECV_LEN) >

Re: [PATCH] i2c: davinci: Add block read functionality for IPMI

2014-05-22 Thread Wolfram Sang
Hi, thanks for the patch. > >+/* capabilities */ > >+#define I2C_CAPABILITIES(I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | \ > >+ I2C_FUNC_SMBUS_READ_BLOCK_DATA) I don't see the need for a seperate define. > >+ > > struct davinci_i2c_dev { > > struct device

RE: [PATCH] i2c: davinci: Add block read functionality for IPMI

2014-05-05 Thread Karicheri, Muralidharan
>-Original Message- >From: Karicheri, Muralidharan >Sent: Thursday, May 01, 2014 2:50 PM >To: davinci-linux-open-sou...@linux.davincidsp.com; linux-...@vger.kernel.org; >linux- >ker...@vger.kernel.org >Cc: Karicheri, Muralidharan; Ding, Garrett; Nori, Sekhar; Kevin Hilman; >Wolfram Sang;