Re: [PATCH] i2c: omap: Fix rumtime PM imbalance on error

2021-04-14 Thread Wolfram Sang
On Wed, Apr 07, 2021 at 11:30:30AM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() will increase the rumtime PM counter > even it returns an error. Thus a pairing decrement is needed > to prevent refcount leak. Fix this by replacing this API with > pm_runtime_resume_and_get(), which will not chan

Re: [PATCH] i2c: omap: Fix rumtime PM imbalance on error

2021-04-07 Thread Tony Lindgren
* Vignesh Raghavendra [210407 07:46]: > Hi, > > On 4/7/21 11:57 AM, Tony Lindgren wrote: > > * Vignesh Raghavendra [210407 06:20]: > >> Do we need a Fixes: tag to enable stable backports? > > > > Well pm_runtime_resume_and_get() was introduced quite recently, and > > we already handle the error

Re: [PATCH] i2c: omap: Fix rumtime PM imbalance on error

2021-04-07 Thread Vignesh Raghavendra
Hi, On 4/7/21 11:57 AM, Tony Lindgren wrote: > * Vignesh Raghavendra [210407 06:20]: >> Do we need a Fixes: tag to enable stable backports? > > Well pm_runtime_resume_and_get() was introduced quite recently, and > we already handle the error and bail out. And likely after an error > not much wor

Re: [PATCH] i2c: omap: Fix rumtime PM imbalance on error

2021-04-06 Thread Tony Lindgren
* Vignesh Raghavendra [210407 06:20]: > Do we need a Fixes: tag to enable stable backports? Well pm_runtime_resume_and_get() was introduced quite recently, and we already handle the error and bail out. And likely after an error not much works anyways :) So it might be better to add just a stable

Re: [PATCH] i2c: omap: Fix rumtime PM imbalance on error

2021-04-06 Thread Vignesh Raghavendra
On 4/7/21 9:00 AM, Dinghao Liu wrote: > pm_runtime_get_sync() will increase the rumtime PM counter > even it returns an error. Thus a pairing decrement is needed > to prevent refcount leak. Fix this by replacing this API with > pm_runtime_resume_and_get(), which will not change the runtime > PM

Re: [PATCH] i2c: omap: Fix rumtime PM imbalance on error

2021-04-06 Thread Tony Lindgren
* Dinghao Liu [210407 03:31]: > pm_runtime_get_sync() will increase the rumtime PM counter > even it returns an error. Thus a pairing decrement is needed > to prevent refcount leak. Fix this by replacing this API with > pm_runtime_resume_and_get(), which will not change the runtime > PM counter on