Re: [PATCH] iio: add ad5761 DAC driver

2016-01-05 Thread Ricardo Ribalda Delgado
This is v5, I forgot to add it to the subject sorry. On Tue, Jan 5, 2016 at 11:41 PM, Ricardo Ribalda Delgado wrote: > ad5761 is a 1-channel DAC with configurable output range. > The driver uses the regulator interface for its voltage ref. > > It shares its register layout with ad5761r, ad5721

Re: [PATCH] iio: add ad5761 DAC driver

2015-12-22 Thread Jonathan Cameron
On 20/12/15 11:19, Ricardo Ribalda Delgado wrote: > Hello Jonthan > > Thanks for your comments, I have fixed all the style problems in v2, > so we can focus in the range parameter. > > On Sat, Dec 19, 2015 at 5:31 PM, Jonathan Cameron wrote: >> Range isn't actually specified in the ABI docs. >>

Re: [PATCH] iio: add ad5761 DAC driver

2015-12-20 Thread Ricardo Ribalda Delgado
Hello Peter: Thanks for your review! I agree on all your points but one: On Sat, Dec 19, 2015 at 6:06 PM, Peter Meerwald-Stadler wrote: >> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ >> + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE) | \ >> + BIT(IIO_CHAN_INF

Re: [PATCH] iio: add ad5761 DAC driver

2015-12-20 Thread Ricardo Ribalda Delgado
Hello Jonthan Thanks for your comments, I have fixed all the style problems in v2, so we can focus in the range parameter. On Sat, Dec 19, 2015 at 5:31 PM, Jonathan Cameron wrote: > Range isn't actually specified in the ABI docs. > Documenation\ABI\testing\sysfs-bus-iio* > The control interface

Re: [PATCH] iio: add ad5761 DAC driver

2015-12-19 Thread Peter Meerwald-Stadler
> ad5761 is a 1-channel DAC with configurable output range. > The driver uses the regulator interface for its voltage ref. some nitpicking below > It shares its register layout with ad5761r, ad5721 and ad5721r. > > Differences: > ad5761* are 16 bit, ad5721* are 12 bits. > ad57*1r have an intern

Re: [PATCH] iio: add ad5761 DAC driver

2015-12-19 Thread Jonathan Cameron
On 16/12/15 13:27, Ricardo Ribalda Delgado wrote: > ad5761 is a 1-channel DAC with configurable output range. > The driver uses the regulator interface for its voltage ref. > > It shares its register layout with ad5761r, ad5721 and ad5721r. > > Differences: > ad5761* are 16 bit, ad5721* are 12 bi