Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-16 Thread Peter Rosin
On 2018-10-16 13:01, Gustavo A. R. Silva wrote: > On 10/14/18 7:01 PM, Jonathan Cameron wrote: >> Done the first of the above... > > Thank you, Jonathan. Indeed. I meant to respond earlier, but then forgot... Thank you! Cheers, Peter

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-16 Thread Gustavo A. R. Silva
On 10/14/18 7:01 PM, Jonathan Cameron wrote: > > Done the first of the above... > Thank you, Jonathan. -- Gustavo

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-14 Thread Jonathan Cameron
On Sat, 13 Oct 2018 15:14:34 + Peter Rosin wrote: > On 2018-10-13 14:38, Jonathan Cameron wrote: > > On Mon, 8 Oct 2018 20:42:41 + > > Peter Rosin wrote: > > > >> On 2018-10-08 19:35, Gustavo A. R. Silva wrote: > >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cas

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-13 Thread Peter Rosin
On 2018-10-13 14:38, Jonathan Cameron wrote: > On Mon, 8 Oct 2018 20:42:41 + > Peter Rosin wrote: > >> On 2018-10-08 19:35, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>> where we are expecting to fall through. >> >> The way I see it,

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-13 Thread Gustavo A. R. Silva
On 10/13/18 2:38 PM, Jonathan Cameron wrote: > On Mon, 8 Oct 2018 20:42:41 + > Peter Rosin wrote: > >> On 2018-10-08 19:35, Gustavo A. R. Silva wrote: >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>> where we are expecting to fall through. >> >> The way I see

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-13 Thread Jonathan Cameron
On Mon, 8 Oct 2018 20:42:41 + Peter Rosin wrote: > On 2018-10-08 19:35, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > The way I see it, it is pretty well marked up as is. So, this paragrap

Re: [PATCH] iio: dpot-dac: mark expected switch fall-through

2018-10-08 Thread Peter Rosin
On 2018-10-08 19:35, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. The way I see it, it is pretty well marked up as is. So, this paragraph is not describing the change. > > Notice that in this particula