Re: [PATCH] input: ims-pcu: remove redundant assignment to variable 'error'

2020-06-03 Thread Colin Ian King
On 03/06/2020 15:45, Dan Carpenter wrote: > On Wed, Jun 03, 2020 at 03:18:46PM +0100, Colin Ian King wrote: >> On 03/06/2020 15:09, Dan Carpenter wrote: >>> On Wed, Jun 03, 2020 at 02:51:02PM +0100, Colin King wrote: From: Colin Ian King The variable error is being initialized with

Re: [PATCH] input: ims-pcu: remove redundant assignment to variable 'error'

2020-06-03 Thread Dan Carpenter
On Wed, Jun 03, 2020 at 03:18:46PM +0100, Colin Ian King wrote: > On 03/06/2020 15:09, Dan Carpenter wrote: > > On Wed, Jun 03, 2020 at 02:51:02PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> The variable error is being initialized with a value that is > >> never read and the -ENOM

Re: [PATCH] input: ims-pcu: remove redundant assignment to variable 'error'

2020-06-03 Thread Colin Ian King
On 03/06/2020 15:09, Dan Carpenter wrote: > On Wed, Jun 03, 2020 at 02:51:02PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The variable error is being initialized with a value that is >> never read and the -ENOMEM error return is being returned anyhow >> by the error exit path to label

Re: [PATCH] input: ims-pcu: remove redundant assignment to variable 'error'

2020-06-03 Thread Dan Carpenter
On Wed, Jun 03, 2020 at 02:51:02PM +0100, Colin King wrote: > From: Colin Ian King > > The variable error is being initialized with a value that is > never read and the -ENOMEM error return is being returned anyhow > by the error exit path to label err_free_mem. The assignment is > redundant and