Re: [PATCH] ip_tunnel: fix ip_tunnel_lookup

2014-07-08 Thread David Miller
From: Dmitry Popov Date: Wed, 9 Jul 2014 04:47:59 +0400 > How I see ip_tunnel_lookup logic: > 1) try to find exact match (and if found return this tunnel): > tunnel.saddr == iph.daddr && tunnel.daddr == iph.saddr && key_matched() > 2) try to find matched (local) wildcard tunnel: > tunnel.saddr ==

Re: [PATCH] ip_tunnel: fix ip_tunnel_lookup

2014-07-08 Thread Dmitry Popov
On Tue, 08 Jul 2014 15:12:10 -0700 (PDT) David Miller wrote: > From: Dmitry Popov > Date: Sat, 5 Jul 2014 02:26:37 +0400 > > > @@ -205,6 +207,8 @@ struct ip_tunnel *ip_tunnel_lookup(struct ip_tunnel_net > > *itn, > > > > hlist_for_each_entry_rcu(t, head, hash_node) { > > if (

Re: [PATCH] ip_tunnel: fix ip_tunnel_lookup

2014-07-08 Thread David Miller
From: Dmitry Popov Date: Sat, 5 Jul 2014 02:26:37 +0400 > @@ -205,6 +207,8 @@ struct ip_tunnel *ip_tunnel_lookup(struct ip_tunnel_net > *itn, > > hlist_for_each_entry_rcu(t, head, hash_node) { > if (t->parms.i_key != key || > + t->parms.iph.saddr != 0 || > +