Re: [PATCH] irq: Consider a negative return value of irq_startup() as an error

2014-03-14 Thread Linus Walleij
On Wed, Mar 12, 2014 at 4:10 PM, Thomas Gleixner wrote: > I pushed out the patch to a separate branch > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip irq/for-gpio > > and merged that branch back into irq/core. > > So you can just pull irq/for-gpio into the gpio work and base the gpio

Re: [PATCH] irq: Consider a negative return value of irq_startup() as an error

2014-03-12 Thread Thomas Gleixner
On Wed, 12 Mar 2014, Linus Walleij wrote: > On Sat, Mar 8, 2014 at 10:15 AM, Thomas Gleixner wrote: > > > On Fri, 7 Mar 2014, Linus Walleij wrote: > >> I'll see what Jean-Jacques comes up with and take it from there unless > >> he's interested in taking it all the way. > > > > Thought more about

Re: [PATCH] irq: Consider a negative return value of irq_startup() as an error

2014-03-12 Thread Linus Walleij
On Sat, Mar 8, 2014 at 10:15 AM, Thomas Gleixner wrote: > On Fri, 7 Mar 2014, Linus Walleij wrote: >> I'll see what Jean-Jacques comes up with and take it from there unless >> he's interested in taking it all the way. > > Thought more about it while trying to come up with a persuasive > argument

Re: [PATCH] irq: Consider a negative return value of irq_startup() as an error

2014-03-08 Thread Thomas Gleixner
On Fri, 7 Mar 2014, Linus Walleij wrote: > I'll see what Jean-Jacques comes up with and take it from there unless > he's interested in taking it all the way. Thought more about it while trying to come up with a persuasive argument for the other Linus to take the irq_startup change that late in the

Re: [PATCH] irq: Consider a negative return value of irq_startup() as an error

2014-03-06 Thread Linus Walleij
On Thu, Feb 27, 2014 at 6:15 AM, Thomas Gleixner wrote: > On Tue, 25 Feb 2014, Jean-Jacques Hiblot wrote: > > The whole drviers/gpio directory is full of this gpio_lock_as_irq() > called from the guts of irq_chip callbacks braindamage. OK then we need to figure out where to place this call to loc

Re: [PATCH] irq: Consider a negative return value of irq_startup() as an error

2014-02-27 Thread Jean-Jacques Hiblot
2014-02-26 23:15 GMT+01:00 Thomas Gleixner : > On Tue, 25 Feb 2014, Jean-Jacques Hiblot wrote: > >> The irq_startup() function returns the return value of the >> irq_startup callback of the underlying irq_chip. Currently this >> value only tells if the interrupt is pending, but we can make it >> al

Re: [PATCH] irq: Consider a negative return value of irq_startup() as an error

2014-02-26 Thread Thomas Gleixner
On Tue, 25 Feb 2014, Jean-Jacques Hiblot wrote: > The irq_startup() function returns the return value of the > irq_startup callback of the underlying irq_chip. Currently this > value only tells if the interrupt is pending, but we can make it > also return an error code when it fails. > > Signed-o