Re: [PATCH] jfs: fix generic posix ACL regression

2014-02-08 Thread Christoph Hellwig
On Sat, Feb 08, 2014 at 10:37:25AM -0600, Dave Kleikamp wrote: > Your patchset removed the XATTR_SYSTEM_PREFIX bits from can_set_xattr, > so it will not recognize the ACL as valid and return -EOPNOTSUPP. Ah, thanks. Consider the patch reviewed: Reviewed-by: Christoph Hellwig -- To unsubscribe f

Re: [PATCH] jfs: fix generic posix ACL regression

2014-02-08 Thread Dave Kleikamp
On 02/08/2014 01:08 AM, Christoph Hellwig wrote: > On Fri, Feb 07, 2014 at 02:59:20PM -0600, Dave Kleikamp wrote: >> -#ifdef JFS_POSIX_ACL >> +#ifdef CONFIG_JFS_POSIX_ACL > > Ooops, sorry. > > I don't understand the can_set_xattr move - while the check obviously > aren't needed when using the gen

Re: [PATCH] jfs: fix generic posix ACL regression

2014-02-07 Thread Christoph Hellwig
On Fri, Feb 07, 2014 at 02:59:20PM -0600, Dave Kleikamp wrote: > -#ifdef JFS_POSIX_ACL > +#ifdef CONFIG_JFS_POSIX_ACL Ooops, sorry. I don't understand the can_set_xattr move - while the check obviously aren't needed when using the generic xattr code I don't see how they cause harm either. -- To

Re: [PATCH] jfs: fix generic posix ACL regression

2014-02-07 Thread Michael L. Semon
Looks good. I'm keeping the patch. It was placed through the following tests: *) the test suite from the January 19 git acl, as root; (git://git.savannah.nongnu.org/acl.git) *) the acl test suite, as a regular user; *) xfstests (full run); and *) some fs_mark and LTP fsstress in a dir pop