Re: [PATCH] kconfig.h: use already defined macros for IS_REACHABLE() define

2016-06-13 Thread Masahiro Yamada
Hi Nicolas, 2016-06-07 7:03 GMT+09:00 Nicolas Pitre : > On Tue, 7 Jun 2016, Masahiro Yamada wrote: > >> Because config_enabled() is so useful, >> maybe people tend to abuse it. >> >> I see one case where config_enabled() is used >> for a non-config macro. >> >> #define __EXPORT_SYMBOL(sym, sec) \

Re: [PATCH] kconfig.h: use already defined macros for IS_REACHABLE() define

2016-06-06 Thread Nicolas Pitre
On Tue, 7 Jun 2016, Masahiro Yamada wrote: > Because config_enabled() is so useful, > maybe people tend to abuse it. > > I see one case where config_enabled() is used > for a non-config macro. > > #define __EXPORT_SYMBOL(sym, sec) \ >__cond_export_sym(sym, sec, config_enabled(__KSYM_

Re: [PATCH] kconfig.h: use already defined macros for IS_REACHABLE() define

2016-06-06 Thread Masahiro Yamada
Hi Linus, 2016-06-07 1:36 GMT+09:00 Linus Torvalds : > Side note: > > On Mon, Jun 6, 2016 at 2:28 AM, Masahiro Yamada > wrote: >> >> -#define IS_REACHABLE(option) (config_enabled(option) || \ >> -(config_enabled(option##_MODULE) && config_enabled(MODULE))) >> +#define IS_REACHABL

Re: [PATCH] kconfig.h: use already defined macros for IS_REACHABLE() define

2016-06-06 Thread Linus Torvalds
Side note: On Mon, Jun 6, 2016 at 2:28 AM, Masahiro Yamada wrote: > > -#define IS_REACHABLE(option) (config_enabled(option) || \ > -(config_enabled(option##_MODULE) && config_enabled(MODULE))) > +#define IS_REACHABLE(option) (IS_BUILTIN(option) || \ > +(IS_MODULE(o