Re: [PATCH] kexec.h: stop exporting kexec_load() to userspace

2014-01-15 Thread H. Peter Anvin
We shouldn't put prototypes of user-space functions in the kernel, at least not until we actually export all the signatures. The prototype should instead be in a userspace header. Maximilian Attems wrote: > >On Wed, Jan 15, 2014 at 02:17:04PM +0100, Paul Bolle wrote: >> Since v3.5 kexec.h is

Re: [PATCH] kexec.h: stop exporting kexec_load() to userspace

2014-01-15 Thread Paul Bolle
On Wed, 2014-01-15 at 14:38 +0100, Maximilian Attems wrote: > On Wed, Jan 15, 2014 at 02:17:04PM +0100, Paul Bolle wrote: > > Since v3.5 kexec.h is exported to userspace. That includes its > > declaration of kexec_load(): > > extern int kexec_load(void *, size_t, struct kexec_segment *, > >

Re: [PATCH] kexec.h: stop exporting kexec_load() to userspace

2014-01-15 Thread Maximilian Attems
On Wed, Jan 15, 2014 at 02:17:04PM +0100, Paul Bolle wrote: > Since v3.5 kexec.h is exported to userspace. That includes its > declaration of kexec_load(): > extern int kexec_load(void *, size_t, struct kexec_segment *, >unsigned long int); > > This declaration isn't very