Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer

2017-04-27 Thread Jacek Anaszewski
On 04/27/2017 05:48 AM, David Lin wrote: > On Tue, Apr 25, 2017 at 1:15 PM, Jacek Anaszewski > wrote: >>> However, there's a need to >>> support hrtimer if the LED subsystem claims support the use case of >>> vibrator (please see Documentation/leds/ledtrig-transient.txt) as even >>> a 5ms of varia

Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer

2017-04-26 Thread David Lin
On Tue, Apr 25, 2017 at 1:15 PM, Jacek Anaszewski wrote: >> However, there's a need to >> support hrtimer if the LED subsystem claims support the use case of >> vibrator (please see Documentation/leds/ledtrig-transient.txt) as even >> a 5ms of variation is perceivable to the user. I'm thinking if

Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer

2017-04-26 Thread Jacek Anaszewski
On 04/26/2017 12:34 AM, Pavel Machek wrote: > On Mon 2017-04-24 20:05:59, David Lin wrote: >> Hi Jacek, >> >> On Mon, Apr 24, 2017 at 12:59 PM, Jacek Anaszewski >> wrote: >>> >>> Hi David, >>> >>> Thanks for the patch. >>> >>> Unfortunately we cannot switch to using hr timers just like that >>> wi

Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer

2017-04-25 Thread Pavel Machek
On Mon 2017-04-24 20:05:59, David Lin wrote: > Hi Jacek, > > On Mon, Apr 24, 2017 at 12:59 PM, Jacek Anaszewski > wrote: > > > > Hi David, > > > > Thanks for the patch. > > > > Unfortunately we cannot switch to using hr timers just like that > > without introducing side effects for many devices.

Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer

2017-04-25 Thread Jacek Anaszewski
Hi David, On 04/25/2017 05:05 AM, David Lin wrote: > Hi Jacek, > > On Mon, Apr 24, 2017 at 12:59 PM, Jacek Anaszewski > wrote: >> >> Hi David, >> >> Thanks for the patch. >> >> Unfortunately we cannot switch to using hr timers just like that >> without introducing side effects for many devices.

Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer

2017-04-24 Thread David Lin
Hi Jacek, On Mon, Apr 24, 2017 at 12:59 PM, Jacek Anaszewski wrote: > > Hi David, > > Thanks for the patch. > > Unfortunately we cannot switch to using hr timers just like that > without introducing side effects for many devices. We had similar > attempt of increasing timer tirgger accuracy two y

Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer

2017-04-24 Thread Pavel Machek
Hi! > Hi David, > > Thanks for the patch. > > Unfortunately we cannot switch to using hr timers just like that > without introducing side effects for many devices. We had similar > attempt of increasing timer tirgger accuracy two years ago [0]. > > In short words, for drivers that can sleep whil

Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer

2017-04-24 Thread Jacek Anaszewski
Hi David, Thanks for the patch. Unfortunately we cannot switch to using hr timers just like that without introducing side effects for many devices. We had similar attempt of increasing timer tirgger accuracy two years ago [0]. In short words, for drivers that can sleep while setting brightness a

Re: [PATCH] led: ledtrig-transient: replace timer_list with hrtimer

2017-04-24 Thread Pavel Machek
On Sun 2017-04-23 21:42:54, David Lin wrote: > This patch replaces the kernel timer used by led transient trigger as an > one-shot timer with an hrtimer. As Android is moving away from the > obsoleted timed_output to ledtrig-transient for the vibrator HAL, > ledtrig-transient needs to be able to ha