Re: [PATCH] leds/trigger/activity: add a system activity LED trigger

2017-08-27 Thread Willy Tarreau
Hi Jacek, On Sun, Aug 27, 2017 at 06:44:05PM +0200, Jacek Anaszewski wrote: > Hi Willy, > > Thanks for the updated patch. > > One formal note: please send the patches with git send-email instead > of attaching them to the message. Yep, I hesitated and wanted to reply. Will do it the other way n

Re: [PATCH] leds/trigger/activity: add a system activity LED trigger

2017-08-27 Thread Jacek Anaszewski
Hi Willy, Thanks for the updated patch. One formal note: please send the patches with git send-email instead of attaching them to the message. It simplifies reviewing and applying patches. For the purpose of this review I just copied the contents of the attachment and pasted as a quotation. Then

Re: [PATCH] leds/trigger/activity: add a system activity LED trigger

2017-08-24 Thread Willy Tarreau
Hi Jacek, On Thu, Mar 09, 2017 at 09:48:39PM +0100, Jacek Anaszewski wrote: > Hi Willy, > > Thanks for the patch. > > Unfortunately I'm getting following build break, while trying to > test it on recent linux-next: > > drivers/leds/trigger/ledtrig-activity.c: In function > 'led_activity_functio

Re: [PATCH] leds/trigger/activity: add a system activity LED trigger

2017-03-09 Thread Willy Tarreau
Hi Jacek, On Thu, Mar 09, 2017 at 09:48:39PM +0100, Jacek Anaszewski wrote: > Hi Willy, > > Thanks for the patch. > > Unfortunately I'm getting following build break, while trying to > test it on recent linux-next: > > drivers/leds/trigger/ledtrig-activity.c: In function > 'led_activity_functio

Re: [PATCH] leds/trigger/activity: add a system activity LED trigger

2017-03-09 Thread Jacek Anaszewski
Hi Willy, Thanks for the patch. Unfortunately I'm getting following build break, while trying to test it on recent linux-next: drivers/leds/trigger/ledtrig-activity.c: In function 'led_activity_function': drivers/leds/trigger/ledtrig-activity.c:67:14: error: implicit declaration of function 'cpu

Re: [PATCH] leds/trigger/activity: add a system activity LED trigger

2017-02-15 Thread Pavel Machek
Hi! > On Wed, Feb 15, 2017 at 11:24:26AM +0100, Pavel Machek wrote: > > On Sun 2017-02-12 00:41:54, Willy Tarreau wrote: > > > The "activity" trigger was inspired by the heartbeat one, but aims at > > > providing instant indication of the immediate CPU usage. Under idle > > > condition, it flashes

Re: [PATCH] leds/trigger/activity: add a system activity LED trigger

2017-02-15 Thread Willy Tarreau
Hi Pavel! On Wed, Feb 15, 2017 at 11:24:26AM +0100, Pavel Machek wrote: > On Sun 2017-02-12 00:41:54, Willy Tarreau wrote: > > The "activity" trigger was inspired by the heartbeat one, but aims at > > providing instant indication of the immediate CPU usage. Under idle > > condition, it flashes 10m

Re: [PATCH] leds/trigger/activity: add a system activity LED trigger

2017-02-15 Thread Pavel Machek
On Sun 2017-02-12 00:41:54, Willy Tarreau wrote: > The "activity" trigger was inspired by the heartbeat one, but aims at > providing instant indication of the immediate CPU usage. Under idle > condition, it flashes 10ms every second. At 100% usage, it flashes > 90ms every 100ms. The blinking freque