Re: [PATCH] lib/string.c: Disable tree-loop-distribute-patterns

2020-08-19 Thread Arvind Sankar
On Tue, Aug 18, 2020 at 08:32:58PM -0700, Linus Torvalds wrote: > On Tue, Aug 18, 2020 at 8:04 PM Arvind Sankar wrote: > > > Might be worth optimizing strnlen etc with the word-at-a-time thing though. > > Yeah, possibly. Except the kernel almost never uses strnlen for > anything bigger. At least

Re: [PATCH] lib/string.c: Disable tree-loop-distribute-patterns

2020-08-18 Thread Linus Torvalds
On Tue, Aug 18, 2020 at 8:04 PM Arvind Sankar wrote: > > On Tue, Aug 18, 2020 at 05:44:03PM -0700, Linus Torvalds wrote: > > Using -fno-tree-loop-distribute-patterns seems to really be a bit too > > incestuous with internal compiler knowledge. > > Fair enough -- you ok with just the -ffreestanding

Re: [PATCH] lib/string.c: Disable tree-loop-distribute-patterns

2020-08-18 Thread Arvind Sankar
On Tue, Aug 18, 2020 at 05:44:03PM -0700, Linus Torvalds wrote: > On Tue, Aug 18, 2020 at 4:43 PM Arvind Sankar wrote: > > > > This by itself is insufficient for gcc if the optimization was > > explicitly enabled by CFLAGS, so also add a flag to explicitly disable > > it. > > Using -fno-tree-loop

Re: [PATCH] lib/string.c: Disable tree-loop-distribute-patterns

2020-08-18 Thread Linus Torvalds
On Tue, Aug 18, 2020 at 4:43 PM Arvind Sankar wrote: > > This by itself is insufficient for gcc if the optimization was > explicitly enabled by CFLAGS, so also add a flag to explicitly disable > it. Using -fno-tree-loop-distribute-patterns seems to really be a bit too incestuous with internal com