Re: [PATCH] lib: rename TEST_MODULE to TEST_LKM

2014-09-29 Thread Kees Cook
On Mon, Sep 29, 2014 at 1:25 PM, Valentin Rothberg wrote: > It has been merged already, see [1]. Sorry, I did not check if you > were in the CC to let you know. If it helps, I tend to use scripts/get_maintainer.pl when sending patches. It's a nice way to see who touched the same areas your patch

Re: [PATCH] lib: rename TEST_MODULE to TEST_LKM

2014-09-29 Thread Kees Cook
On Mon, Sep 29, 2014 at 1:36 PM, Paul Bolle wrote: > On Mon, 2014-09-29 at 22:25 +0200, Valentin Rothberg wrote: >> On Mon, Sep 29, 2014 at 10:18 PM, Paul Bolle wrote: >> > Maybe something like "TEST_MODULE_LOAD"? >> >> It has been merged already, see [1]. Sorry, I did not check if you >> were in

Re: [PATCH] lib: rename TEST_MODULE to TEST_LKM

2014-09-29 Thread Paul Bolle
On Mon, 2014-09-29 at 22:25 +0200, Valentin Rothberg wrote: > On Mon, Sep 29, 2014 at 10:18 PM, Paul Bolle wrote: > > Maybe something like "TEST_MODULE_LOAD"? > > It has been merged already, see [1]. Sorry, I did not check if you > were in the CC to let you know. > > [1] > http://ozlabs.org/~ak

Re: [PATCH] lib: rename TEST_MODULE to TEST_LKM

2014-09-29 Thread Valentin Rothberg
On Mon, Sep 29, 2014 at 10:18 PM, Paul Bolle wrote: > [Perhaps Kees hasn't seen this yet.] > > On Tue, 2014-09-23 at 20:27 +0200, Valentin Rothberg wrote: >> On mar., 2014-09-23 at 10:11 -0700, Randy Dunlap wrote: >> > On 09/23/14 10:10, Valentin Rothberg wrote: >> > > On mar., 2014-09-23 at 09:49

Re: [PATCH] lib: rename TEST_MODULE to TEST_LKM

2014-09-29 Thread Paul Bolle
[Perhaps Kees hasn't seen this yet.] On Tue, 2014-09-23 at 20:27 +0200, Valentin Rothberg wrote: > On mar., 2014-09-23 at 10:11 -0700, Randy Dunlap wrote: > > On 09/23/14 10:10, Valentin Rothberg wrote: > > > On mar., 2014-09-23 at 09:49 -0700, Randy Dunlap wrote: > > >> On 09/22/14 23:58, Valenti

Re: [PATCH] lib: rename TEST_MODULE to TEST_LKM

2014-09-23 Thread Valentin Rothberg
On mar., 2014-09-23 at 10:11 -0700, Randy Dunlap wrote: > On 09/23/14 10:10, Valentin Rothberg wrote: > > On mar., 2014-09-23 at 09:49 -0700, Randy Dunlap wrote: > >> On 09/22/14 23:58, Valentin Rothberg wrote: > >>> The "_MODULE" suffix is reserved for tristates compiled as > >>> loadable kernel m

Re: [PATCH] lib: rename TEST_MODULE to TEST_LKM

2014-09-23 Thread Randy Dunlap
On 09/23/14 10:10, Valentin Rothberg wrote: > On mar., 2014-09-23 at 09:49 -0700, Randy Dunlap wrote: >> On 09/22/14 23:58, Valentin Rothberg wrote: >>> The "_MODULE" suffix is reserved for tristates compiled as >>> loadable kernel modules (LKM). The "TEST_MODULE" feature thereby >> >> Is that docu

Re: [PATCH] lib: rename TEST_MODULE to TEST_LKM

2014-09-23 Thread Valentin Rothberg
On mar., 2014-09-23 at 09:49 -0700, Randy Dunlap wrote: > On 09/22/14 23:58, Valentin Rothberg wrote: > > The "_MODULE" suffix is reserved for tristates compiled as > > loadable kernel modules (LKM). The "TEST_MODULE" feature thereby > > Is that documented anywhere? Sadly this is not made explici

Re: [PATCH] lib: rename TEST_MODULE to TEST_LKM

2014-09-23 Thread Randy Dunlap
On 09/22/14 23:58, Valentin Rothberg wrote: > The "_MODULE" suffix is reserved for tristates compiled as > loadable kernel modules (LKM). The "TEST_MODULE" feature thereby Is that documented anywhere? Was this causing some kind of problem or error? Please tell us what that was if so. > violat